Patchwork drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment

login
register
mail settings
Submitter René Bolldorf
Date Jan. 7, 2010, 10:18 p.m.
Message ID <4B465DA1.6010300@googlemail.com>
Download mbox | patch
Permalink /patch/42482/
State New
Headers show

Comments

René Bolldorf - Jan. 7, 2010, 10:18 p.m.

Artem Bityutskiy - Jan. 13, 2010, 5:32 a.m.
On Thu, 2010-01-07 at 23:18 +0100, René Bolldorf wrote:
> --- ./drivers/mtd/chips/cfi_probe.c     2009-12-28 21:09:46.638828686 +0100
> +++ ./drivers/mtd/chips/cfi_probe.c     2010-01-04 22:38:31.536678726 +0100
> @@ -18,8 +18,6 @@
>   #include <linux/mtd/cfi.h>
>   #include <linux/mtd/gen_probe.h>
> 
> -//#define DEBUG_CFI
> -
>   #ifdef DEBUG_CFI
>   static void print_cfi_ident(struct cfi_ident *);
>   #endif

I do not think this is is needed. The commented out define shows what
one should do to debug the thing. Without that line it is not so
obvious. So, nack from me.

Patch

--- ./drivers/mtd/chips/cfi_probe.c     2009-12-28 21:09:46.638828686 +0100
+++ ./drivers/mtd/chips/cfi_probe.c     2010-01-04 22:38:31.536678726 +0100
@@ -18,8 +18,6 @@ 
  #include <linux/mtd/cfi.h>
  #include <linux/mtd/gen_probe.h>

-//#define DEBUG_CFI
-
  #ifdef DEBUG_CFI
  static void print_cfi_ident(struct cfi_ident *);
  #endif