| Message ID | 1420030733-10374-3-git-send-email-linux@rempel-privat.de |
|---|---|
| State | Accepted |
| Commit | 0cb850486048ba4f64482a9d3e33dff47df34c79 |
| Headers | show |
On Wed, 31 Dec 2014 13:58:53 +0100 Oleksij Rempel <linux@rempel-privat.de> wrote: > Add the full description of the Toshiba TC58NVG0S3E NAND chip in the > nand_ids table so that we can later use the NAND ECC infos and ONFI timings > mode in controller drivers. > > Tested with asm9260_nand driver. > > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/mtd/nand/nand_ids.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c > index fbde8910..47b5cdf 100644 > --- a/drivers/mtd/nand/nand_ids.c > +++ b/drivers/mtd/nand/nand_ids.c > @@ -31,6 +31,10 @@ struct nand_flash_dev nand_flash_ids[] = { > * listed by full ID. We list them first so that we can easily identify > * the most specific match. > */ > + {"TC58NVG0S3E 1G 3.3V 8-bit", > + { .id = {0x98, 0xd1, 0x90, 0x15, 0x76, 0x14, 0x01, 0x00} }, > + SZ_2K, SZ_128, SZ_128K, 0, 8, 64, NAND_ECC_INFO(1, SZ_512), > + 2 }, > {"TC58NVG2S0F 4G 3.3V 8-bit", > { .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08} }, > SZ_4K, SZ_512, SZ_256K, 0, 8, 224, NAND_ECC_INFO(4, SZ_512) },
An old one here... On Wed, Dec 31, 2014 at 01:58:53PM +0100, Oleksij Rempel wrote: > Add the full description of the Toshiba TC58NVG0S3E NAND chip in the > nand_ids table so that we can later use the NAND ECC infos and ONFI timings > mode in controller drivers. > > Tested with asm9260_nand driver. Looks like this driver work stalled? > Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> This patch looks good anyway, so pushed to l2-mtd.git. Brian
Hi, Am 25.08.2015 um 21:25 schrieb Brian Norris: > An old one here... > > On Wed, Dec 31, 2014 at 01:58:53PM +0100, Oleksij Rempel wrote: >> Add the full description of the Toshiba TC58NVG0S3E NAND chip in the >> nand_ids table so that we can later use the NAND ECC infos and ONFI timings >> mode in controller drivers. >> >> Tested with asm9260_nand driver. > > Looks like this driver work stalled? Yea, i'm working on other project. The company with asm9260_nand chip asked not to be named any more. I assume, they have some legal issues. I can continue to work on this in my free time, but i need some suggestion how to handle this issue. Any ideas? > >> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> > > This patch looks good anyway, so pushed to l2-mtd.git. Thx > Brian > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ >
Hi Oleksij, On Wed, Aug 26, 2015 at 06:00:38AM +0200, Oleksij Rempel wrote: > Am 25.08.2015 um 21:25 schrieb Brian Norris: > > An old one here... > > > > On Wed, Dec 31, 2014 at 01:58:53PM +0100, Oleksij Rempel wrote: > >> Add the full description of the Toshiba TC58NVG0S3E NAND chip in the > >> nand_ids table so that we can later use the NAND ECC infos and ONFI timings > >> mode in controller drivers. > >> > >> Tested with asm9260_nand driver. > > > > Looks like this driver work stalled? > > Yea, i'm working on other project. The company with asm9260_nand chip > asked not to be named any more. I assume, they have some legal issues. I > can continue to work on this in my free time, but i need some suggestion > how to handle this issue. Any ideas? Well, I'm not a lawyer, and I can't give legal advice. But AIUI, as long as you can fulfill the Developer's Certificate of Origin (see Documentation/SubmittingPatches), then you can still contribute code. It's on you to clear up whether you have "the right to submit it under the open source license indicated in the file." (IANAL double: but given that the original submissions are already out on the mailing lists under GPLv2 (the Signed-off-by), nothing would stop random developer X from picking up your work and upstreaming it, without any additional permission.) Brian
diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c index fbde8910..47b5cdf 100644 --- a/drivers/mtd/nand/nand_ids.c +++ b/drivers/mtd/nand/nand_ids.c @@ -31,6 +31,10 @@ struct nand_flash_dev nand_flash_ids[] = { * listed by full ID. We list them first so that we can easily identify * the most specific match. */ + {"TC58NVG0S3E 1G 3.3V 8-bit", + { .id = {0x98, 0xd1, 0x90, 0x15, 0x76, 0x14, 0x01, 0x00} }, + SZ_2K, SZ_128, SZ_128K, 0, 8, 64, NAND_ECC_INFO(1, SZ_512), + 2 }, {"TC58NVG2S0F 4G 3.3V 8-bit", { .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08} }, SZ_4K, SZ_512, SZ_256K, 0, 8, 224, NAND_ECC_INFO(4, SZ_512) },
Add the full description of the Toshiba TC58NVG0S3E NAND chip in the nand_ids table so that we can later use the NAND ECC infos and ONFI timings mode in controller drivers. Tested with asm9260_nand driver. Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> --- drivers/mtd/nand/nand_ids.c | 4 ++++ 1 file changed, 4 insertions(+)