diff mbox

[v2] dnsmasq: install DBus configuration file

Message ID 1419972927-25825-1-git-send-email-yegorslists@googlemail.com
State Superseded
Headers show

Commit Message

Yegor Yefremov Dec. 30, 2014, 8:55 p.m. UTC
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes:
	v2: fix indentation

 package/dnsmasq/dnsmasq.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Thomas Petazzoni Dec. 30, 2014, 9:44 p.m. UTC | #1
Dear Yegor Yefremov,

On Tue, 30 Dec 2014 21:55:27 +0100, Yegor Yefremov wrote:

> +ifeq ($(BR2_PACKAGE_DBUS),y)
> +define DNSMASQ_INSTALL_DBUS
> +	$(INSTALL) -D $(@D)/dbus/dnsmasq.conf \
> +		$(TARGET_DIR)/etc/dbus-1/system.d/dnsmasq.conf

Sorry, should have said that on the previous iteration: please add -m
0644 to the $(INSTALL) invocation.

Thanks!

Thomas
Yegor Yefremov Dec. 30, 2014, 11:18 p.m. UTC | #2
On Tue, Dec 30, 2014 at 10:44 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Yegor Yefremov,
>
> On Tue, 30 Dec 2014 21:55:27 +0100, Yegor Yefremov wrote:
>
>> +ifeq ($(BR2_PACKAGE_DBUS),y)
>> +define DNSMASQ_INSTALL_DBUS
>> +     $(INSTALL) -D $(@D)/dbus/dnsmasq.conf \
>> +             $(TARGET_DIR)/etc/dbus-1/system.d/dnsmasq.conf
>
> Sorry, should have said that on the previous iteration: please add -m
> 0644 to the $(INSTALL) invocation.

Should I apply these changes to wpa_supplicant too? I borrowed the code there.

Yegor
Thomas Petazzoni Dec. 31, 2014, 7:47 a.m. UTC | #3
Dear Yegor Yefremov,

On Wed, 31 Dec 2014 00:18:17 +0100, Yegor Yefremov wrote:

> > Sorry, should have said that on the previous iteration: please add -m
> > 0644 to the $(INSTALL) invocation.
> 
> Should I apply these changes to wpa_supplicant too? I borrowed the code there.

Yes, doing those changes on wpa_supplicant would be good. Thanks a lot!

Thomas
diff mbox

Patch

diff --git a/package/dnsmasq/dnsmasq.mk b/package/dnsmasq/dnsmasq.mk
index 9b1092e..1de4439 100644
--- a/package/dnsmasq/dnsmasq.mk
+++ b/package/dnsmasq/dnsmasq.mk
@@ -101,9 +101,17 @@  define DNSMASQ_BUILD_CMDS
 	$(DNSMASQ_MAKE_ENV) $(MAKE1) -C $(@D) $(DNSMASQ_MAKE_OPTS) all$(DNSMASQ_I18N)
 endef
 
+ifeq ($(BR2_PACKAGE_DBUS),y)
+define DNSMASQ_INSTALL_DBUS
+	$(INSTALL) -D $(@D)/dbus/dnsmasq.conf \
+		$(TARGET_DIR)/etc/dbus-1/system.d/dnsmasq.conf
+endef
+endif
+
 define DNSMASQ_INSTALL_TARGET_CMDS
 	$(DNSMASQ_MAKE_ENV) $(MAKE) -C $(@D) $(DNSMASQ_MAKE_OPTS) install$(DNSMASQ_I18N)
 	mkdir -p $(TARGET_DIR)/var/lib/misc/
+	$(DNSMASQ_INSTALL_DBUS)
 endef
 
 define DNSMASQ_INSTALL_INIT_SYSV