| Message ID | 1419957035-1078-4-git-send-email-vladz@cloudius-systems.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Dec 30, 2014 at 8:30 AM, Vlad Zolotarov <vladz@cloudius-systems.com> wrote: > 82599 VFs and PF share the same RSS Key. Therefore we will return > the same RSS key for all VFs. > > Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 2 ++ > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 25 +++++++++++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h > index c1123d9..52e775b 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h > @@ -97,6 +97,8 @@ enum ixgbe_pfvf_api_rev { > #define IXGBE_VF_GET_RETA_1 0x0b /* get RETA[12..23] */ > #define IXGBE_VF_GET_RETA_2 0x0c /* get RETA[24..31] */ > > +#define IXGBE_VF_GET_RSS_KEY 0x0d /* get RSS key */ > + > /* GET_QUEUES return data indices within the mailbox */ > #define IXGBE_VF_TX_QUEUES 1 /* number of Tx queues supported */ > #define IXGBE_VF_RX_QUEUES 2 /* number of Rx queues supported */ > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c > index 84db1a5..fc8233e 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c > @@ -970,6 +970,28 @@ static int ixgbe_get_vf_reta(struct ixgbe_adapter *adapter, > return 0; > } > > +static int ixgbe_get_vf_rss_key(struct ixgbe_adapter *adapter, > + u32 *msgbuf, u32 vf) > +{ > + struct ixgbe_hw *hw = &adapter->hw; > + int i; > + u32 *rss_key = &msgbuf[1]; > + > + /* verify the PF is supporting the correct API */ > + switch (adapter->vfinfo[vf].vf_api) { > + case ixgbe_mbox_api_12: > + break; > + default: > + return -EPERM; > + } Same as in patch 01 of the series, a switch statement is overkill for a single case. It would be far simpler to just have if (adapter->vfinfo[vf].vf_api != ixgbe_mbox_api_12) return -EPERM; Later on, if there are multiple API's or future API's that also support this, then we could move to a case statement. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/30/14 21:23, Jeff Kirsher wrote: > On Tue, Dec 30, 2014 at 8:30 AM, Vlad Zolotarov > <vladz@cloudius-systems.com> wrote: >> 82599 VFs and PF share the same RSS Key. Therefore we will return >> the same RSS key for all VFs. >> >> Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com> >> --- >> drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 2 ++ >> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 25 +++++++++++++++++++++++++ >> 2 files changed, 27 insertions(+) >> >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h >> index c1123d9..52e775b 100644 >> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h >> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h >> @@ -97,6 +97,8 @@ enum ixgbe_pfvf_api_rev { >> #define IXGBE_VF_GET_RETA_1 0x0b /* get RETA[12..23] */ >> #define IXGBE_VF_GET_RETA_2 0x0c /* get RETA[24..31] */ >> >> +#define IXGBE_VF_GET_RSS_KEY 0x0d /* get RSS key */ >> + >> /* GET_QUEUES return data indices within the mailbox */ >> #define IXGBE_VF_TX_QUEUES 1 /* number of Tx queues supported */ >> #define IXGBE_VF_RX_QUEUES 2 /* number of Rx queues supported */ >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c >> index 84db1a5..fc8233e 100644 >> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c >> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c >> @@ -970,6 +970,28 @@ static int ixgbe_get_vf_reta(struct ixgbe_adapter *adapter, >> return 0; >> } >> >> +static int ixgbe_get_vf_rss_key(struct ixgbe_adapter *adapter, >> + u32 *msgbuf, u32 vf) >> +{ >> + struct ixgbe_hw *hw = &adapter->hw; >> + int i; >> + u32 *rss_key = &msgbuf[1]; >> + >> + /* verify the PF is supporting the correct API */ >> + switch (adapter->vfinfo[vf].vf_api) { >> + case ixgbe_mbox_api_12: >> + break; >> + default: >> + return -EPERM; >> + } > Same as in patch 01 of the series, a switch statement is overkill for > a single case. It would be far simpler to just have > > if (adapter->vfinfo[vf].vf_api != ixgbe_mbox_api_12) > return -EPERM; > > Later on, if there are multiple API's or future API's that also > support this, then we could move to a case statement. Got it. Will fix. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h index c1123d9..52e775b 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h @@ -97,6 +97,8 @@ enum ixgbe_pfvf_api_rev { #define IXGBE_VF_GET_RETA_1 0x0b /* get RETA[12..23] */ #define IXGBE_VF_GET_RETA_2 0x0c /* get RETA[24..31] */ +#define IXGBE_VF_GET_RSS_KEY 0x0d /* get RSS key */ + /* GET_QUEUES return data indices within the mailbox */ #define IXGBE_VF_TX_QUEUES 1 /* number of Tx queues supported */ #define IXGBE_VF_RX_QUEUES 2 /* number of Rx queues supported */ diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c index 84db1a5..fc8233e 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -970,6 +970,28 @@ static int ixgbe_get_vf_reta(struct ixgbe_adapter *adapter, return 0; } +static int ixgbe_get_vf_rss_key(struct ixgbe_adapter *adapter, + u32 *msgbuf, u32 vf) +{ + struct ixgbe_hw *hw = &adapter->hw; + int i; + u32 *rss_key = &msgbuf[1]; + + /* verify the PF is supporting the correct API */ + switch (adapter->vfinfo[vf].vf_api) { + case ixgbe_mbox_api_12: + break; + default: + return -EPERM; + } + + /* Read the RSS KEY */ + for (i = 0; i < 10; i++) + rss_key[i] = IXGBE_READ_REG(hw, IXGBE_RSSRK(i)); + + return 0; +} + static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf) { u32 mbx_size = IXGBE_VFMAILBOX_SIZE; @@ -1035,6 +1057,9 @@ static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf) case IXGBE_VF_GET_RETA_2: retval = ixgbe_get_vf_reta(adapter, msgbuf, vf, 24, 8); break; + case IXGBE_VF_GET_RSS_KEY: + retval = ixgbe_get_vf_rss_key(adapter, msgbuf, vf); + break; default: e_err(drv, "Unhandled Msg %8.8x\n", msgbuf[0]); retval = IXGBE_ERR_MBX;
82599 VFs and PF share the same RSS Key. Therefore we will return the same RSS key for all VFs. Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 2 ++ drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 25 +++++++++++++++++++++++++ 2 files changed, 27 insertions(+)