diff mbox

net.git: Call-trace after "Merge branch 'netlink_multicast'"

Message ID CA+icZUUO5fkmdevyhutYU6=2vBACN0Nr3WA+DMssfhy5xfsrbQ@mail.gmail.com
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Sedat Dilek Dec. 28, 2014, 9:34 a.m. UTC 
On Sun, Dec 28, 2014 at 8:54 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> Just a small thing, if you look at this...
>
> With gcc-4.9.2 I see this warning in my logs...
>
> net/netlink/genetlink.c: In function 'genl_bind':
> net/netlink/genetlink.c:1018:2: warning: 'err' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>

Attached patch fixes the issue for me.

- Sedat -
diff mbox

Patch

From af3eaa7a784be23db14a4a0f509ded474e6e0852 Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.dilek@gmail.com>
Date: Sun, 28 Dec 2014 09:21:12 +0100
Subject: [PATCH] genetlink: Fix uninitialized err variable in genl_bind()

This fixes the following compilere (here: gcc-4.9) warning:

net/netlink/genetlink.c: In function 'genl_bind':
net/netlink/genetlink.c:1018:2: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]

CC: Johannes Berg <johannes.berg@intel.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: "linux-netdev" <netdev@vger.kernel.org>
Fixes: c380d9a7afff ("genetlink: pass multicast bind/unbind to families")
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 net/netlink/genetlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
index 5cfbcea..44ad6e3 100644
--- a/net/netlink/genetlink.c
+++ b/net/netlink/genetlink.c
@@ -985,7 +985,7 @@  static struct genl_multicast_group genl_ctrl_groups[] = {
 
 static int genl_bind(struct net *net, int group)
 {
-	int i, err;
+	int err = 0, i;
 	bool found = false;
 
 	down_read(&cb_lock);
-- 
2.2.1