| Message ID | CA+icZUVkNHBqCn66onJP9i5vfVzHR9mdSFXyiBFyjhkrySrSzQ@mail.gmail.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Dec 28, 2014 at 6:39 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote: [ ... ] > [ CCing Fengguang Wu who reported the same issue on LKML (see [0]) ] > > Was "netlink/genetlink: pass network namespace to bind/unbind" patch > [1] forgotten in this 'netlink_multicast' merge? OK, this patch is additional and on top of "[PATCH 0/5] netlink/genetlink cleanups & multicast improvements" - Sedat - [1] http://marc.info/?l=linux-netdev&w=2&r=1&s=netlink&q=b > I also tested with that patch on top of net.git#master. > The warning still remains. > > I have #if 0-ed the WARN_ON() for now (see attached patch), this makes > the warning go away for me. > > BTW, I looked through the patches listed in [2] but this list seems to > be truncated. > Then I looked again at the linux-netdev ML where I found Johannes' > patch and Dave replied "Applied, thanks Johannes." (see thread in > [3]). > Forgot to push out? > > - Sedat - > > [0] http://marc.info/?l=linux-kernel&m=141972716410805&w=2 > [1] http://patchwork.ozlabs.org/patch/423799/ > [2] http://patchwork.ozlabs.org/project/netdev/list/ > [3] http://marc.info/?t=141936487400002&r=1&w=2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Just a small thing, if you look at this... With gcc-4.9.2 I see this warning in my logs... net/netlink/genetlink.c: In function 'genl_bind': net/netlink/genetlink.c:1018:2: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] - Sedat - P.S.: Some gcc-4.9 outputs $ cat /proc/version Linux version 3.19.0-rc1-58.2-iniza-small (sedat.dilek@gmail.com@fambox) (gcc version 4.9.2 (Ubuntu 4.9.2-0ubuntu1~12.04) ) #1 SMP Sun Dec 28 08:09:51 CET 2014 $ gcc-4.9 -v Using built-in specs. COLLECT_GCC=gcc-4.9 COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.9/lto-wrapper Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.9.2-0ubuntu1~12.04' --with-bugurl=file:///usr/share/doc/gcc-4.9/README.Bugs --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.9 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.9 --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.9-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.9-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.9-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 4.9.2 (Ubuntu 4.9.2-0ubuntu1~12.04) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Dec 28, 2014 at 7:22 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote: > On Sun, Dec 28, 2014 at 6:39 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote: > [ ... ] >> [ CCing Fengguang Wu who reported the same issue on LKML (see [0]) ] >> >> Was "netlink/genetlink: pass network namespace to bind/unbind" patch >> [1] forgotten in this 'netlink_multicast' merge? > > OK, this patch is additional and on top of "[PATCH 0/5] > netlink/genetlink cleanups & multicast improvements" > Thanks, now I can see that patch in net.git#master. - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=023e2cfa36c31b0ad28c159a1bb0d61ff57334c8 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From 02730e1fb7ffda68f16abdf310d36fabc4e25154 Mon Sep 17 00:00:00 2001 From: Sedat Dilek <sedat.dilek@gmail.com> Date: Sat, 27 Dec 2014 17:36:23 +0100 Subject: [PATCH] genetlink: Comment out WARN_ON() in genl_bind() Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com> --- net/netlink/genetlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 05bf40b..3637369 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -1008,8 +1008,10 @@ static int genl_bind(int group) } up_read(&cb_lock); +#if 0 if (WARN_ON(!found)) err = 0; +#endif return err; } -- 2.2.1