| Message ID | dc7aed907743824f29e6000e45e01388ae8cf0dd.1419704115.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > FreeRDP mis-detects the CPU, and may enable Neon extensions when it > should not. Not all ARM processors have Neon extensions. > Heck, what's more, none non-ARM processor has Neon extensions! > The regexp to detect the CPU is borked: 'arm*' will also match 'arc' > as well as 'arm'. Huh, how does arm* march arc?
Peter, All, On 2014-12-28 12:31 +0100, Peter Korsgaard spake thusly: > >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > > > FreeRDP mis-detects the CPU, and may enable Neon extensions when it > > should not. Not all ARM processors have Neon extensions. > > > Heck, what's more, none non-ARM processor has Neon extensions! > > The regexp to detect the CPU is borked: 'arm*' will also match 'arc' > > as well as 'arm'. > > Huh, how does arm* march arc? Already answered on IRC, but for the records: this is not a glob, this is a regexp. Regards, Yann E. MORIN.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: Hi, >> > Heck, what's more, none non-ARM processor has Neon extensions! >> > The regexp to detect the CPU is borked: 'arm*' will also match 'arc' >> > as well as 'arm'. >> >> Huh, how does arm* march arc? > Already answered on IRC, but for the records: this is not a glob, this > is a regexp. Yes, thanks.
diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk index d2e51f8..c9396b5 100644 --- a/package/freerdp/freerdp.mk +++ b/package/freerdp/freerdp.mk @@ -63,4 +63,10 @@ else FREERDP_CONF_OPTS += -DWITH_XV=OFF endif +ifeq ($(BR2_ARM_CPU_HAS_NEON),y) +FREERDP_CONF_OPTS += -DWITH_NEON=ON +else +FREERDP_CONF_OPTS += -DWITH_NEON=OFF +endif + $(eval $(cmake-package))
FreeRDP mis-detects the CPU, and may enable Neon extensions when it should not. Not all ARM processors have Neon extensions. Heck, what's more, none non-ARM processor has Neon extensions! The regexp to detect the CPU is borked: 'arm*' will also match 'arc' as well as 'arm'. Do not let FreeRDP try to decide if it can use Neon extensions, we have a Kconfig option for that, that we can use to force FreeRDP to use it or not. Should fix: http://autobuild.buildroot.org/results/d4a/d4a61e686cf11d993d02ece0c4e2835a926603c2/ http://autobuild.buildroot.org/results/234/2349d40ef8d658ab1cd7332eb1b42a75afcd423f/ ... Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- Note: fixing the regexp would be nice, and can be sent upstream, but now we force use or not of Neon, we can do without further patching FreeRDP. --- package/freerdp/freerdp.mk | 6 ++++++ 1 file changed, 6 insertions(+)