diff mbox

[MIPS] Remove some multilibs from mips-mti-linux-gnu target

Message ID 4478f636-a166-49ab-805b-bf5f4171bf74@BAMAIL02.ba.imgtec.org
State New
Headers show

Commit Message

Steve Ellcey Dec. 24, 2014, 5:12 p.m. UTC 
This patch removes mips32[r1] and mips64[r1] from the list of
mips-mti-linux-gnu architectures built with -mnan=2008.  They
should never have been included since these architectures do not
support the ieee 2008 format (GCC warns and ignores the nan flag).

The recent changes to glibc to use -Werror mean that the warning
GCC gives is treated as an error and that glibc will not build with
these flag combinations so I would like to remove them from the
GCC mips-mti-linux-gnu multilib list.

This does not affect any GCC target other then mips-mti-linux.gnu.

OK to checkin?

Steve Ellcey
sellcey@imgtec.com


2014-12-24  Steve Ellcey  <sellcey@mips.com>

	* config/mips/t-mti-linux (MULTILIB_EXCEPTIONS): Add exceptions
	for mips32[r1] and mips64[r1] with -mnan=2008.

Comments

Matthew Fortune Dec. 29, 2014, 8:23 a.m. UTC | #1 
> 2014-12-24  Steve Ellcey  <sellcey@mips.com>
> 
> 	* config/mips/t-mti-linux (MULTILIB_EXCEPTIONS): Add exceptions
> 	for mips32[r1] and mips64[r1] with -mnan=2008.

This is OK, but I think it may be best to fix t-mti-elf at the same
time even though it is probably building but with warnings.

Thanks,
Matthew
Steve Ellcey Dec. 29, 2014, 4:45 p.m. UTC | #2 
> From: Matthew Fortune

> > 2014-12-24  Steve Ellcey  <sellcey@mips.com>
> >
> >       * config/mips/t-mti-linux (MULTILIB_EXCEPTIONS): Add exceptions
> >       for mips32[r1] and mips64[r1] with -mnan=2008.

> This is OK, but I think it may be best to fix t-mti-elf at the same
> time even though it is probably building but with warnings.

Good point.  I made the same change to t-mti-elf and checked them both in.

Steve Ellcey
sellcey@imgtec.com
diff mbox

Patch

diff --git a/gcc/config/mips/t-mti-linux b/gcc/config/mips/t-mti-linux
index 487a015..c111532 100644
--- a/gcc/config/mips/t-mti-linux
+++ b/gcc/config/mips/t-mti-linux
@@ -41,5 +41,8 @@  MULTILIB_EXCEPTIONS += *mips32/mmicromips*
 MULTILIB_EXCEPTIONS += *mips64*/mmicromips*
 MULTILIB_EXCEPTIONS += *mmicromips/mabi=64*
 
-# We do not want nan2008 libraries for soft-float.
+# We do not want nan2008 libraries for soft-float,
+# mips32[r1], or mips64[r1].
 MULTILIB_EXCEPTIONS += *msoft-float*/*mnan=2008*
+MULTILIB_EXCEPTIONS += *mips32/*mnan=2008*
+MULTILIB_EXCEPTIONS += *mips64/*mnan=2008*