| Message ID | 1419379909-8025-1-git-send-email-anthoine.bourgeois@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hi, Anthoine Bourgeois wrote: > Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com> > --- > > include/configs/devkit8000.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h > index 930b08e..77e2f58 100644 > --- a/include/configs/devkit8000.h > +++ b/include/configs/devkit8000.h > @@ -21,6 +21,7 @@ > #define CONFIG_MACH_TYPE MACH_TYPE_DEVKIT8000 > #define CONFIG_OMAP_GPIO > #define CONFIG_OMAP_COMMON > +#define CONFIG_SYS_GENERIC_BOARD I try this patch with my devkit8000 board and it works well but I wonder if the devkit8000.h configuration should inherit the ti_omap3_common.h configuration. I can do those modifications but is it a good idea ? Is it worth to try ? Thanks, Anthoine
Hi, Anthoine Bourgeois wrote: > Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com> > --- > > include/configs/devkit8000.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h > index 930b08e..77e2f58 100644 > --- a/include/configs/devkit8000.h > +++ b/include/configs/devkit8000.h > @@ -21,6 +21,7 @@ > #define CONFIG_MACH_TYPE MACH_TYPE_DEVKIT8000 > #define CONFIG_OMAP_GPIO > #define CONFIG_OMAP_COMMON > +#define CONFIG_SYS_GENERIC_BOARD I try this patch with my devkit8000 board and it works well but I wonder if the devkit8000.h configuration should inherit the ti_omap3_common.h configuration. I can do those modifications but is it a good idea ? Is it worth to try ? Thanks, Anthoine
On Sun, Dec 28, 2014 at 05:59:31PM +0100, Anthoine Bourgeois wrote: > Hi, > > Anthoine Bourgeois wrote: > > > Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com> > > --- > > > > include/configs/devkit8000.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h > > index 930b08e..77e2f58 100644 > > --- a/include/configs/devkit8000.h > > +++ b/include/configs/devkit8000.h > > @@ -21,6 +21,7 @@ > > #define CONFIG_MACH_TYPE MACH_TYPE_DEVKIT8000 > > #define CONFIG_OMAP_GPIO > > #define CONFIG_OMAP_COMMON > > +#define CONFIG_SYS_GENERIC_BOARD > > I try this patch with my devkit8000 board and it works well but I wonder > if the devkit8000.h configuration should inherit the ti_omap3_common.h > configuration. I can do those modifications but is it a good idea ? Is > it worth to try ? It would be appreciated, yes, thanks!
On Wed, Dec 24, 2014 at 01:11:49AM +0100, Anthoine Bourgeois wrote:
> Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
Since we're close to release, I'm taking this now and will take your
patches to further clean up the config after release, applied to
u-boot/master, thanks!
diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h index 930b08e..77e2f58 100644 --- a/include/configs/devkit8000.h +++ b/include/configs/devkit8000.h @@ -21,6 +21,7 @@ #define CONFIG_MACH_TYPE MACH_TYPE_DEVKIT8000 #define CONFIG_OMAP_GPIO #define CONFIG_OMAP_COMMON +#define CONFIG_SYS_GENERIC_BOARD /* * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com> --- include/configs/devkit8000.h | 1 + 1 file changed, 1 insertion(+)