diff mbox

[U-Boot,1/5] x86: Remove include directory in arch/x86/dts

Message ID 1419397600-7431-1-git-send-email-bmeng.cn@gmail.com
State Rejected
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng Dec. 24, 2014, 5:06 a.m. UTC
The include directory in arch/x86/dts is not used, so remove it.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 arch/x86/dts/include/dt-bindings | 1 -
 1 file changed, 1 deletion(-)
 delete mode 120000 arch/x86/dts/include/dt-bindings

\ No newline at end of file

Comments

Simon Glass Dec. 28, 2014, 1:02 a.m. UTC | #1
Hi Bin,

On 23 December 2014 at 22:06, Bin Meng <bmeng.cn@gmail.com> wrote:
> The include directory in arch/x86/dts is not used, so remove it.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---

Actually we do need this - the Chrome OS keyboard .dtsi will use a
binding when I get around to updating it.

>
>  arch/x86/dts/include/dt-bindings | 1 -
>  1 file changed, 1 deletion(-)
>  delete mode 120000 arch/x86/dts/include/dt-bindings
>
> diff --git a/arch/x86/dts/include/dt-bindings b/arch/x86/dts/include/dt-bindings
> deleted file mode 120000
> index 0cecb3d..0000000
> --- a/arch/x86/dts/include/dt-bindings
> +++ /dev/null
> @@ -1 +0,0 @@
> -../../../../include/dt-bindings
> \ No newline at end of file
> --
> 1.8.2.1
>

Regards,
Simon
Bin Meng Dec. 29, 2014, 6:04 a.m. UTC | #2
Hi Simon,

On Sun, Dec 28, 2014 at 9:02 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Bin,
>
> On 23 December 2014 at 22:06, Bin Meng <bmeng.cn@gmail.com> wrote:
>> The include directory in arch/x86/dts is not used, so remove it.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>
> Actually we do need this - the Chrome OS keyboard .dtsi will use a
> binding when I get around to updating it.
>

OK, so maybe we can just put anything we do need into the include
instead of a symbolic link to the genric one?

Regards,
Bin
Simon Glass Dec. 29, 2014, 7:39 p.m. UTC | #3
Hi Bin,

On 28 December 2014 at 23:04, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Simon,
>
> On Sun, Dec 28, 2014 at 9:02 AM, Simon Glass <sjg@chromium.org> wrote:
>> Hi Bin,
>>
>> On 23 December 2014 at 22:06, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> The include directory in arch/x86/dts is not used, so remove it.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>> ---
>>
>> Actually we do need this - the Chrome OS keyboard .dtsi will use a
>> binding when I get around to updating it.
>>
>
> OK, so maybe we can just put anything we do need into the include
> instead of a symbolic link to the genric one?

The idea as (I understand it) is that include/dt-bindings is the
standard directory for all archs to put their bindings. This is how
ARM works too.

Regards,
Simon
Bin Meng Dec. 30, 2014, 1:57 a.m. UTC | #4
Hi Simon,

On Tue, Dec 30, 2014 at 3:39 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Bin,
>
> On 28 December 2014 at 23:04, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Hi Simon,
>>
>> On Sun, Dec 28, 2014 at 9:02 AM, Simon Glass <sjg@chromium.org> wrote:
>>> Hi Bin,
>>>
>>> On 23 December 2014 at 22:06, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>> The include directory in arch/x86/dts is not used, so remove it.
>>>>
>>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>>>> ---
>>>
>>> Actually we do need this - the Chrome OS keyboard .dtsi will use a
>>> binding when I get around to updating it.
>>>
>>
>> OK, so maybe we can just put anything we do need into the include
>> instead of a symbolic link to the genric one?
>
> The idea as (I understand it) is that include/dt-bindings is the
> standard directory for all archs to put their bindings. This is how
> ARM works too.
>

OK, thanks for the clarification.

Regards,
Bin
diff mbox

Patch

diff --git a/arch/x86/dts/include/dt-bindings b/arch/x86/dts/include/dt-bindings
deleted file mode 120000
index 0cecb3d..0000000
--- a/arch/x86/dts/include/dt-bindings
+++ /dev/null
@@ -1 +0,0 @@ 
-../../../../include/dt-bindings