| Message ID | 1419328019-27254-1-git-send-email-shh.xie@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 12/23/2014 12:46 PM, shh.xie@gmail.com wrote: > From: Shaohui Xie <Shaohui.Xie@freescale.com> > Which is wrong and not used, so no extra space needed by > mdio_alloc_size(), change the parameter accordingly. > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com> > --- > drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c > index 90adba1..72e0b85 100644 > --- a/drivers/net/ethernet/freescale/xgmac_mdio.c > +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c > @@ -187,14 +187,13 @@ static int xgmac_mdio_probe(struct platform_device *pdev) > return ret; > } > > - bus = mdiobus_alloc_size(PHY_MAX_ADDR * sizeof(int)); > + bus = mdiobus_alloc_size(0); It's now equivalent to a mere mdiobus_alloc(). [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: Tuesday, December 23, 2014 10:12 PM > To: shh.xie@gmail.com; netdev@vger.kernel.org; davem@davemloft.net > Cc: Xie Shaohui-B21989 > Subject: Re: [PATCH 2/3] net/fsl: remove irq assignment from xgmac_mdio > > Hello. > > On 12/23/2014 12:46 PM, shh.xie@gmail.com wrote: > > > From: Shaohui Xie <Shaohui.Xie@freescale.com> > > > Which is wrong and not used, so no extra space needed by > > mdio_alloc_size(), change the parameter accordingly. > > > Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com> > > --- > > drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c > > b/drivers/net/ethernet/freescale/xgmac_mdio.c > > index 90adba1..72e0b85 100644 > > --- a/drivers/net/ethernet/freescale/xgmac_mdio.c > > +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c > > @@ -187,14 +187,13 @@ static int xgmac_mdio_probe(struct > platform_device *pdev) > > return ret; > > } > > > > - bus = mdiobus_alloc_size(PHY_MAX_ADDR * sizeof(int)); > > + bus = mdiobus_alloc_size(0); > > It's now equivalent to a mere mdiobus_alloc(). [S.H] Yes, mdiobus_alloc() defined as: static inline struct mii_bus *mdiobus_alloc(void) { return mdiobus_alloc_size(0); } Should I use mdiobus_alloc() instead? Thanks! Shaohui -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 12/24/2014 5:22 AM, Shaohui Xie wrote: [...] >>> From: Shaohui Xie <Shaohui.Xie@freescale.com> >>> Which is wrong and not used, so no extra space needed by >>> mdio_alloc_size(), change the parameter accordingly. >>> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com> >>> --- >>> drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c >>> b/drivers/net/ethernet/freescale/xgmac_mdio.c >>> index 90adba1..72e0b85 100644 >>> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c >>> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c >>> @@ -187,14 +187,13 @@ static int xgmac_mdio_probe(struct platform_device *pdev) >>> return ret; >>> } >>> >>> - bus = mdiobus_alloc_size(PHY_MAX_ADDR * sizeof(int)); >>> + bus = mdiobus_alloc_size(0); >> It's now equivalent to a mere mdiobus_alloc(). > [S.H] Yes, mdiobus_alloc() defined as: > static inline struct mii_bus *mdiobus_alloc(void) > { > return mdiobus_alloc_size(0); > } > Should I use mdiobus_alloc() instead? Yes, I meant it. > Thanks! > Shaohui WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index 90adba1..72e0b85 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -187,14 +187,13 @@ static int xgmac_mdio_probe(struct platform_device *pdev) return ret; } - bus = mdiobus_alloc_size(PHY_MAX_ADDR * sizeof(int)); + bus = mdiobus_alloc_size(0); if (!bus) return -ENOMEM; bus->name = "Freescale XGMAC MDIO Bus"; bus->read = xgmac_mdio_read; bus->write = xgmac_mdio_write; - bus->irq = bus->priv; bus->parent = &pdev->dev; snprintf(bus->id, MII_BUS_ID_SIZE, "%llx", (unsigned long long)res.start);