Patchwork [v2,RESEND,04/11] Cocoa: Silence type warning

login
register
mail settings
Submitter Andreas Färber
Date Jan. 6, 2010, 10:47 p.m.
Message ID <1262818037-926-5-git-send-email-andreas.faerber@web.de>
Download mbox | patch
Permalink /patch/42358/
State New
Headers show

Comments

Andreas Färber - Jan. 6, 2010, 10:47 p.m.
Add const for "qemu" character literal, to avoid:

warning: initialization discards qualifiers from pointer target type

An earlier patch by John proposed to use char[5]. Since we do not modify
the text and later copy it into malloc'ed memory, marking it as const
seems sufficient.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: John Arbuckle <programmingkidx@gmail.com>
---
 cocoa.m |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/cocoa.m b/cocoa.m
index f8c2e00..0a95c77 100644
--- a/cocoa.m
+++ b/cocoa.m
@@ -791,7 +791,7 @@  static int cocoa_keycode_to_qemu(int keycode)
     if(returnCode == NSCancelButton) {
         exit(0);
     } else if(returnCode == NSOKButton) {
-        char *bin = "qemu";
+        const char *bin = "qemu";
         char *img = (char*)[ [ sheet filename ] cStringUsingEncoding:NSASCIIStringEncoding];
 
         char **argv = (char**)malloc( sizeof(char*)*3 );