| Message ID | 1418969138-26199-1-git-send-email-maheshb@google.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Thu, Dec 18, 2014 at 10:05:38PM -0800, Mahesh Bandewar wrote: > The command 'ip netns identify' without PID parameter is supposed to > use the self PID to identify its ns but a trivial error prevented it > from doing so. This patch fixes that error. > > So before the patch - > # ip netns id > No pid specified > # echo $? > 1 > # > > After the patch - > # ip netns id > test-ns > # echo $? > 0 > # > > Signed-off-by: Mahesh Bandewar <maheshb@google.com> > Cc: Stephen Hemminger <stephen@networkplumber.org> > Cc: Vadim Kochan <vadim4j@gmail.com> > Cc: Saied Kazemi <saied@google.com> > --- > ip/ipnetns.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ip/ipnetns.c b/ip/ipnetns.c > index 1c8aa029073e..ec9afa2177a5 100644 > --- a/ip/ipnetns.c > +++ b/ip/ipnetns.c > @@ -298,7 +298,7 @@ static int netns_identify(int argc, char **argv) > DIR *dir; > struct dirent *entry; > > - if (argc < 1) { > + if (!argc) { > pidstr = "self"; > } else if (argc > 1) { > fprintf(stderr, "extra arguments specified\n"); > -- > 2.2.0.rc0.207.ga3a616c > Hi Mahesh, I did not get such error on the current master branch? Did I miss something ? Regards, Vadim Kochan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 19, 2014 at 12:31 AM, Vadim Kochan <vadim4j@gmail.com> wrote: > On Thu, Dec 18, 2014 at 10:05:38PM -0800, Mahesh Bandewar wrote: >> The command 'ip netns identify' without PID parameter is supposed to >> use the self PID to identify its ns but a trivial error prevented it >> from doing so. This patch fixes that error. >> >> So before the patch - >> # ip netns id >> No pid specified >> # echo $? >> 1 >> # >> >> After the patch - >> # ip netns id >> test-ns >> # echo $? >> 0 >> # >> >> Signed-off-by: Mahesh Bandewar <maheshb@google.com> >> Cc: Stephen Hemminger <stephen@networkplumber.org> >> Cc: Vadim Kochan <vadim4j@gmail.com> >> Cc: Saied Kazemi <saied@google.com> >> --- >> ip/ipnetns.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ip/ipnetns.c b/ip/ipnetns.c >> index 1c8aa029073e..ec9afa2177a5 100644 >> --- a/ip/ipnetns.c >> +++ b/ip/ipnetns.c >> @@ -298,7 +298,7 @@ static int netns_identify(int argc, char **argv) >> DIR *dir; >> struct dirent *entry; >> >> - if (argc < 1) { >> + if (!argc) { >> pidstr = "self"; >> } else if (argc > 1) { >> fprintf(stderr, "extra arguments specified\n"); >> -- >> 2.2.0.rc0.207.ga3a616c >> > > Hi Mahesh, > > I did not get such error on the current master branch? > > Did I miss something ? > No you did not! Please ignore this patch. :) Looks like the tree I was working / using wasn't next and did not have the patch that made it work (in next). I cherry-picked my fix onto the next and sent it. My bad! > Regards, > Vadim Kochan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 1c8aa029073e..ec9afa2177a5 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -298,7 +298,7 @@ static int netns_identify(int argc, char **argv) DIR *dir; struct dirent *entry; - if (argc < 1) { + if (!argc) { pidstr = "self"; } else if (argc > 1) { fprintf(stderr, "extra arguments specified\n");
The command 'ip netns identify' without PID parameter is supposed to use the self PID to identify its ns but a trivial error prevented it from doing so. This patch fixes that error. So before the patch - # ip netns id No pid specified # echo $? 1 # After the patch - # ip netns id test-ns # echo $? 0 # Signed-off-by: Mahesh Bandewar <maheshb@google.com> Cc: Stephen Hemminger <stephen@networkplumber.org> Cc: Vadim Kochan <vadim4j@gmail.com> Cc: Saied Kazemi <saied@google.com> --- ip/ipnetns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)