hw/ppc/e500.c : Fix GPIO IRQ Number.
diff mbox

Message ID BL2PR03MB449DD6BFED31BC53029822F836A0@BL2PR03MB449.namprd03.prod.outlook.com
State New
Headers show

Commit Message

Amit Tomar Dec. 18, 2014, 2:28 p.m. UTC
Provided appropriate subject line.

Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
---
 hw/ppc/e500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.7.9.5


-----Original Message-----
From: Alexander Graf [mailto:agraf@suse.de] 
Sent: Wednesday, December 17, 2014 2:52 PM
To: Tomar Amit-B51888; qemu-devel@nongnu.org; qemu-ppc@nongnu.org
Subject: Re: [PATCH] QEMU:Change the IRQ number for GPIO Controller


On 17.12.14 10:18, Amit Tomar wrote:
> Ping :)
> 
> -----Original Message-----
> From: Tomar Amit-B51888
> Sent: Monday, December 08, 2014 3:03 PM
> To: 'qemu-devel@nongnu.org'; 'qemu-ppc@nongnu.org'
> Cc: 'agraf@suse.de'
> Subject: [PATCH] QEMU:Change the IRQ number for GPIO Controller
> 
> As per RM and following links IRQ 43 is for I2C controller and IRQ 47 is for GPIO controller.
> 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-January/087924.ht
> ml
> http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/fsl/pq3-gpi
> o-0.dtsi?v=3.4
> 
> 
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>

Please change the subject line to something that allows people skimming through the patches to know that it modifies ppc e500 code.

Otherwise looks good to me.

Alex

Comments

Alexander Graf Dec. 18, 2014, 4:48 p.m. UTC | #1
On 18.12.14 15:28, Amit Tomar wrote:
> 
> Provided appropriate subject line.

This time around the patch description is wrong :(. Please just post a
full new patch with a good subject line and a good patch description.

In the git tree, all history from email communication will be gone.
People will only see the subject line, patch description and patch body
that you provide in the latest version of the patch. So please make sure
that this is golden :).


Alex

> 
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
> ---
>  hw/ppc/e500.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -65,7 +65,7 @@
>  #define MPC8544_UTIL_OFFSET        0xe0000ULL
>  #define MPC8544_SPIN_BASE          0xEF000000ULL
>  #define MPC8XXX_GPIO_OFFSET        0x000FF000ULL
> -#define MPC8XXX_GPIO_IRQ           43
> +#define MPC8XXX_GPIO_IRQ           47
> 
>  struct boot_info
>  {
> --
> 1.7.9.5
> 
> 
> -----Original Message-----
> From: Alexander Graf [mailto:agraf@suse.de] 
> Sent: Wednesday, December 17, 2014 2:52 PM
> To: Tomar Amit-B51888; qemu-devel@nongnu.org; qemu-ppc@nongnu.org
> Subject: Re: [PATCH] QEMU:Change the IRQ number for GPIO Controller
> 
> 
> On 17.12.14 10:18, Amit Tomar wrote:
>> Ping :)
>>
>> -----Original Message-----
>> From: Tomar Amit-B51888
>> Sent: Monday, December 08, 2014 3:03 PM
>> To: 'qemu-devel@nongnu.org'; 'qemu-ppc@nongnu.org'
>> Cc: 'agraf@suse.de'
>> Subject: [PATCH] QEMU:Change the IRQ number for GPIO Controller
>>
>> As per RM and following links IRQ 43 is for I2C controller and IRQ 47 is for GPIO controller.
>>
>> https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-January/087924.ht
>> ml
>> http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/fsl/pq3-gpi
>> o-0.dtsi?v=3.4
>>
>>
>> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
> 
> Please change the subject line to something that allows people skimming through the patches to know that it modifies ppc e500 code.
> 
> Otherwise looks good to me.
> 
> Alex
>

Patch
diff mbox

diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -65,7 +65,7 @@ 
 #define MPC8544_UTIL_OFFSET        0xe0000ULL
 #define MPC8544_SPIN_BASE          0xEF000000ULL
 #define MPC8XXX_GPIO_OFFSET        0x000FF000ULL
-#define MPC8XXX_GPIO_IRQ           43
+#define MPC8XXX_GPIO_IRQ           47

 struct boot_info
 {