| Message ID | 1418852858-818-2-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8 @public.gmane.org> wrote in news:1418852858-818-2-git-send-email- thomas.petazzoni@free-electrons.com: > Do we want to apply this right now? We already have a lot of failures > caused by the static/shared change. Do we want to have more? [...] > + configlines.append("BR2_COMPILER_PARANOID_UNSAFE_PATH=y\n") Hi, I vote for yes. Regards, Bernd
Thomas, All, On 2014-12-17 22:47 +0100, Thomas Petazzoni spake thusly: > Now that Buildroot has support for paranoid path checking (check for > clearly invalid header and library directories used when > cross-compiling), let's enable this in the autobuilders. > > Without this, the paranoid path checking only emits warnings. With > this patch enabled, whenever an invalid header or library path is > used, the build will stop and fail, which will allow us to clearly > notice such cases. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > Do we want to apply this right now? We already have a lot of failures > caused by the static/shared change. Do we want to have more? Well, either we set it right now, so we have time to investigate before the 2015.02 release, or we post-pone that for after. We're almost one mont in the release cycle, with a bit more than another month before rc1, so it might be already too late for the switch, but it is still doable. So: Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN.
Hi Thomas, Le 17/12/2014 22:47, Thomas Petazzoni a écrit : > Now that Buildroot has support for paranoid path checking (check for > clearly invalid header and library directories used when > cross-compiling), let's enable this in the autobuilders. > > Without this, the paranoid path checking only emits warnings. With > this patch enabled, whenever an invalid header or library path is > used, the build will stop and fail, which will allow us to clearly > notice such cases. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > Do we want to apply this right now? We already have a lot of failures > caused by the static/shared change. Do we want to have more? > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > Several packages have already been fixed since this feature has been added. Enabling this check now will help to discover the remaining packages left to fix. Acked-by: Romain Naour <romain.naour@openwide.fr> Best regards, Romain
Dear Romain Naour, On Fri, 26 Dec 2014 18:51:12 +0100, Romain Naour wrote: > Several packages have already been fixed since this feature has been > added. Enabling this check now will help to discover the remaining > packages left to fix. > > Acked-by: Romain Naour <romain.naour@openwide.fr> The patch has been committed, however the new version of the script has not yet been deployed on the autobuilders. Thomas
Hi Thomas, Le 26/12/2014 19:09, Thomas Petazzoni a écrit : > Dear Romain Naour, > > On Fri, 26 Dec 2014 18:51:12 +0100, Romain Naour wrote: > >> Several packages have already been fixed since this feature has been >> added. Enabling this check now will help to discover the remaining >> packages left to fix. >> >> Acked-by: Romain Naour <romain.naour@openwide.fr> > The patch has been committed, however the new version of the script has > not yet been deployed on the autobuilders. > > Thomas Ok, thanks. I thought it was not because I didn't see any failure. Best regards, Romain
diff --git a/scripts/autobuild-run b/scripts/autobuild-run index ce89e1e..b27b2fc 100755 --- a/scripts/autobuild-run +++ b/scripts/autobuild-run @@ -341,6 +341,7 @@ def gen_config(instance, log, sysinfo): # Amend the configuration with a few things. configlines.append("BR2_PACKAGE_BUSYBOX_SHOW_OTHERS=y\n") configlines.append("# BR2_TARGET_ROOTFS_TAR is not set\n") + configlines.append("BR2_COMPILER_PARANOID_UNSAFE_PATH=y\n") if randint(0, 20) == 0: configlines.append("BR2_ENABLE_DEBUG=y\n") if randint(0, 30) == 0: