diff mbox

[v4] package/gdb: fix shared-only build

Message ID 1418852225-7144-1-git-send-email-romain.naour@openwide.fr
State Accepted
Headers show

Commit Message

Romain Naour Dec. 17, 2014, 9:37 p.m. UTC
The shared build only of gdb is actually not supported.

When --disable-static is given to the gdb's main configure script,
it also disable the static build of bundled libraries like bfd, readline
and opcodes, which must be build statically.

Force the static build of bundled libraries by adding --enable-static in
GDB_CONF_OPTS.

Fixes:
http://autobuild.buildroot.net/results/219/21979e730dca1fce5bdda9a4c7fad4485e788866/
http://autobuild.buildroot.net/results/c10/c1096d0bd22de5c6feba848f743601ad0416a944/
http://autobuild.buildroot.net/results/d8a/d8a5bcc7fa374fb0c916a9d0f33ef283109cb404/
http://autobuild.buildroot.net/results/22a/22a86d0f1df0fc4698c0f734f3d659e6317404a4/
http://autobuild.buildroot.net/results/404/404e61e5c30040ee5756f4b5839149dca38660d4/

And many more.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
v4: Fix typos (ThomasP)
v3: Add a comment in gdb.mk (ThomasP)
v2: D'ont patch gdb, just enable static build.
---
 package/gdb/gdb.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Yann E. MORIN Dec. 21, 2014, 8:41 p.m. UTC | #1
Romain, All,

On 2014-12-17 22:37 +0100, Romain Naour spake thusly:
> The shared build only of gdb is actually not supported.
> 
> When --disable-static is given to the gdb's main configure script,
> it also disable the static build of bundled libraries like bfd, readline
> and opcodes, which must be build statically.
> 
> Force the static build of bundled libraries by adding --enable-static in
> GDB_CONF_OPTS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/219/21979e730dca1fce5bdda9a4c7fad4485e788866/
> http://autobuild.buildroot.net/results/c10/c1096d0bd22de5c6feba848f743601ad0416a944/
> http://autobuild.buildroot.net/results/d8a/d8a5bcc7fa374fb0c916a9d0f33ef283109cb404/
> http://autobuild.buildroot.net/results/22a/22a86d0f1df0fc4698c0f734f3d659e6317404a4/
> http://autobuild.buildroot.net/results/404/404e61e5c30040ee5756f4b5839149dca38660d4/
> 
> And many more.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

This is starting to bug some real users, as recently reported on the IRC
channel.

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v4: Fix typos (ThomasP)
> v3: Add a comment in gdb.mk (ThomasP)
> v2: D'ont patch gdb, just enable static build.
> ---
>  package/gdb/gdb.mk | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index dbec760..aa22193 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -74,6 +74,8 @@ GDB_CONF_ENV = \
>  	bash_cv_have_mbstate_t=yes \
>  	gdb_cv_func_sigsetjmp=yes
>  
> +# The shared only build is not supported by gdb, so enable static build for
> +# build-in libraries with --enable-static.
>  GDB_CONF_OPTS = \
>  	--without-uiout \
>  	--disable-gdbtk \
> @@ -83,7 +85,8 @@ GDB_CONF_OPTS = \
>  	$(if $(BR2_PACKAGE_GDB_SERVER),--enable-gdbserver) \
>  	--with-curses \
>  	--without-included-gettext \
> -	--disable-werror
> +	--disable-werror \
> +	--enable-static
>  
>  ifeq ($(BR2_PACKAGE_GDB_TUI),y)
>  	GDB_CONF_OPTS += --enable-tui
> -- 
> 1.9.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni Dec. 21, 2014, 9:05 p.m. UTC | #2
Dear Romain Naour,

On Wed, 17 Dec 2014 22:37:05 +0100, Romain Naour wrote:
> The shared build only of gdb is actually not supported.
> 
> When --disable-static is given to the gdb's main configure script,
> it also disable the static build of bundled libraries like bfd, readline
> and opcodes, which must be build statically.
> 
> Force the static build of bundled libraries by adding --enable-static in
> GDB_CONF_OPTS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/219/21979e730dca1fce5bdda9a4c7fad4485e788866/
> http://autobuild.buildroot.net/results/c10/c1096d0bd22de5c6feba848f743601ad0416a944/
> http://autobuild.buildroot.net/results/d8a/d8a5bcc7fa374fb0c916a9d0f33ef283109cb404/
> http://autobuild.buildroot.net/results/22a/22a86d0f1df0fc4698c0f734f3d659e6317404a4/
> http://autobuild.buildroot.net/results/404/404e61e5c30040ee5756f4b5839149dca38660d4/
> 
> And many more.
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index dbec760..aa22193 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -74,6 +74,8 @@  GDB_CONF_ENV = \
 	bash_cv_have_mbstate_t=yes \
 	gdb_cv_func_sigsetjmp=yes
 
+# The shared only build is not supported by gdb, so enable static build for
+# build-in libraries with --enable-static.
 GDB_CONF_OPTS = \
 	--without-uiout \
 	--disable-gdbtk \
@@ -83,7 +85,8 @@  GDB_CONF_OPTS = \
 	$(if $(BR2_PACKAGE_GDB_SERVER),--enable-gdbserver) \
 	--with-curses \
 	--without-included-gettext \
-	--disable-werror
+	--disable-werror \
+	--enable-static
 
 ifeq ($(BR2_PACKAGE_GDB_TUI),y)
 	GDB_CONF_OPTS += --enable-tui