| Message ID | 1418835576.1160.38.camel@dcbw.local |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 17/12/14 08:59, Dan Williams wrote: > Signed-off-by: Dan Williams <dcbw@redhat.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Documentation/ABI/testing/sysfs-class-net | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-net b/Documentation/ABI/testing/sysfs-class-net > index e1b2e78..7fe823a 100644 > --- a/Documentation/ABI/testing/sysfs-class-net > +++ b/Documentation/ABI/testing/sysfs-class-net > @@ -186,7 +186,12 @@ KernelVersion: 3.12 > Contact: netdev@vger.kernel.org > Description: > Indicates the interface unique physical port identifier within > - the NIC, as a string. > + the NIC, as a string. If two net_device objects share physical > + hardware or other resources, and/or do not operate independently > + both net_device objects should be assigned the > + same phys_port_id. phys_port_id should be as globally unique > + as possible to prevent conflicts between different drivers and > + vendors, eg with MAC addresses or hardware GUIDs. > > What: /sys/class/net/<iface>/speed > Date: October 2009 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev- > > Signed-off-by: Dan Williams <dcbw@redhat.com> > --- > Documentation/ABI/testing/sysfs-class-net | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/sysfs-class-net > b/Documentation/ABI/testing/sysfs-class-net > index e1b2e78..7fe823a 100644 > --- a/Documentation/ABI/testing/sysfs-class-net > +++ b/Documentation/ABI/testing/sysfs-class-net > @@ -186,7 +186,12 @@ KernelVersion: 3.12 > Contact: netdev@vger.kernel.org > Description: > Indicates the interface unique physical port identifier within > - the NIC, as a string. > + the NIC, as a string. If two net_device objects share physical > + hardware or other resources, and/or do not operate > independently > + both net_device objects should be assigned the > + same phys_port_id. phys_port_id should be as globally > unique > + as possible to prevent conflicts between different drivers > and > + vendors, eg with MAC addresses or hardware GUIDs. Dan, two interfaces -- on the same card/chip -- may share some chip resources, but as long as they use *separate* physical ports, it would be OK to bond them. So, in this case, it would be valid to report a different phys_port_id for these netdevs. The text -- "share physical hardware or other resources" becomes too restrictive ^^^^^^^^^^^^^^^ and will not even allow bonding of two physical ports on a NIC card. thks, -Sathya > > What: /sys/class/net/<iface>/speed > Date: October 2009 > -- > 1.9.3 > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2014-12-18 at 05:57 +0000, Sathya Perla wrote: > > -----Original Message----- > > From: netdev-owner@vger.kernel.org [mailto:netdev- > > > > Signed-off-by: Dan Williams <dcbw@redhat.com> > > --- > > Documentation/ABI/testing/sysfs-class-net | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/ABI/testing/sysfs-class-net > > b/Documentation/ABI/testing/sysfs-class-net > > index e1b2e78..7fe823a 100644 > > --- a/Documentation/ABI/testing/sysfs-class-net > > +++ b/Documentation/ABI/testing/sysfs-class-net > > @@ -186,7 +186,12 @@ KernelVersion: 3.12 > > Contact: netdev@vger.kernel.org > > Description: > > Indicates the interface unique physical port identifier within > > - the NIC, as a string. > > + the NIC, as a string. If two net_device objects share physical > > + hardware or other resources, and/or do not operate > > independently > > + both net_device objects should be assigned the > > + same phys_port_id. phys_port_id should be as globally > > unique > > + as possible to prevent conflicts between different drivers > > and > > + vendors, eg with MAC addresses or hardware GUIDs. > > Dan, two interfaces -- on the same card/chip -- may share some chip resources, > but as long as they use *separate* physical ports, it would be OK to bond them. > So, in this case, it would be valid to report a different phys_port_id for these netdevs. > > The text -- "share physical hardware or other resources" becomes too restrictive > ^^^^^^^^^^^^^^^ > and will not even allow bonding of two physical ports on a NIC card. Fair enough, I will reword and resubmit. Dan > thks, > -Sathya > > > > What: /sys/class/net/<iface>/speed > > Date: October 2009 > > -- > > 1.9.3 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe netdev" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/ABI/testing/sysfs-class-net b/Documentation/ABI/testing/sysfs-class-net index e1b2e78..7fe823a 100644 --- a/Documentation/ABI/testing/sysfs-class-net +++ b/Documentation/ABI/testing/sysfs-class-net @@ -186,7 +186,12 @@ KernelVersion: 3.12 Contact: netdev@vger.kernel.org Description: Indicates the interface unique physical port identifier within - the NIC, as a string. + the NIC, as a string. If two net_device objects share physical + hardware or other resources, and/or do not operate independently + both net_device objects should be assigned the + same phys_port_id. phys_port_id should be as globally unique + as possible to prevent conflicts between different drivers and + vendors, eg with MAC addresses or hardware GUIDs. What: /sys/class/net/<iface>/speed Date: October 2009
Signed-off-by: Dan Williams <dcbw@redhat.com> --- Documentation/ABI/testing/sysfs-class-net | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)