diff mbox

[BUILDROBOT] MSP430: Fix unused arg warning

Message ID 20141217165356.GE31195@lug-owl.de
State New
Headers show

Commit Message

Jan-Benedict Glaw Dec. 17, 2014, 4:53 p.m. UTC
Hi!

The build robot found this:

g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include  -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace   -o msp430.o -MT msp430.o -MMD -MP -MF ./.deps/msp430.TPo ../../../gcc/gcc/config/msp430/msp430.c
../../../gcc/gcc/config/msp430/msp430.c:979:43: error: unused parameter ‘file’ [-Werror=unused-parameter]
 msp430_asm_output_addr_const_extra (FILE *file, rtx x)
                                           ^
cc1plus: all warnings being treated as errors
make[2]: *** [msp430.o] Error 1

(See for example this build:
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=384666)


Ok for this one?


2014-12-17  Jan-Benedict Glaw  <jbglaw@lug-owl.de>

	* config/msp430/msp430.c (msp430_asm_output_addr_const_extra): Fix
	unused argument warning.

Comments

Nick Clifton Dec. 17, 2014, 5:05 p.m. UTC | #1
Hi Jan-Benedict,

> 2014-12-17  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
>
> 	* config/msp430/msp430.c (msp430_asm_output_addr_const_extra): Fix
> 	unused argument warning.

Approved - please apply.

Cheers
   Nick
Jan-Benedict Glaw Dec. 17, 2014, 5:11 p.m. UTC | #2
Hi Nick,

On Wed, 2014-12-17 17:05:09 +0000, Nicholas Clifton <nickc@redhat.com> wrote:
> > 2014-12-17  Jan-Benedict Glaw  <jbglaw@lug-owl.de>
> >
> >	* config/msp430/msp430.c (msp430_asm_output_addr_const_extra): Fix
> >	unused argument warning.
> 
> Approved - please apply.

Thanks. Committed as r218828.

MfG, JBG
diff mbox

Patch

diff --git a/gcc/config/msp430/msp430.c b/gcc/config/msp430/msp430.c
index fe97f27..bf29e18 100644
--- a/gcc/config/msp430/msp430.c
+++ b/gcc/config/msp430/msp430.c
@@ -976,7 +976,7 @@  msp430_asm_integer (rtx x, unsigned int size, int aligned_p)
 #undef  TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA
 #define TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA msp430_asm_output_addr_const_extra
 static bool
-msp430_asm_output_addr_const_extra (FILE *file, rtx x)
+msp430_asm_output_addr_const_extra (FILE *file ATTRIBUTE_UNUSED, rtx x)
 {
   debug_rtx(x);
   return false;