diff mbox

hw/net/xen_nic.c: Set 'netdev->mac' to NULL after free it

Message ID 54909D02.2030404@gmail.com
State New
Headers show

Commit Message

Chen Gang Dec. 16, 2014, 8:58 p.m. UTC 
Since net_init() checks whether 'netdev->mac' is NULL, before alloc it;
net_release() also need set 'netdev->mac' to NULL after free it.

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 hw/net/xen_nic.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Hajnoczi Jan. 7, 2015, 4:01 p.m. UTC | #1 
On Wed, Dec 17, 2014 at 04:58:42AM +0800, Chen Gang wrote:
> Since net_init() checks whether 'netdev->mac' is NULL, before alloc it;
> net_release() also need set 'netdev->mac' to NULL after free it.
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  hw/net/xen_nic.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan
diff mbox

Patch

diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c
index 8eaa77b..19ecfc4 100644
--- a/hw/net/xen_nic.c
+++ b/hw/net/xen_nic.c
@@ -428,6 +428,7 @@  static int net_free(struct XenDevice *xendev)
         netdev->nic = NULL;
     }
     g_free(netdev->mac);
+    netdev->mac = NULL;
     return 0;
 }