From patchwork Tue Jan 5 06:27:32 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 42200 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AB213B6EF0 for ; Wed, 6 Jan 2010 08:40:14 +1100 (EST) Received: from localhost ([127.0.0.1]:39311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSH8N-0002Gh-Ex for incoming@patchwork.ozlabs.org; Tue, 05 Jan 2010 16:40:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSFQ3-0007d3-Gl for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:50:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSFPx-0007Yn-Qt for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:50:18 -0500 Received: from [199.232.76.173] (port=40930 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSFPx-0007YZ-If for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:50:13 -0500 Received: from mx20.gnu.org ([199.232.41.8]:36255) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSFPx-0003Ef-8A for qemu-devel@nongnu.org; Tue, 05 Jan 2010 14:50:13 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NS2uN-0003p6-3N for qemu-devel@nongnu.org; Tue, 05 Jan 2010 01:28:47 -0500 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id 6607118288; Tue, 5 Jan 2010 15:27:43 +0900 (JST) Received: (nullmailer pid 22662 invoked by uid 1000); Tue, 05 Jan 2010 06:27:50 -0000 From: Isaku Yamahata To: qemu-devel@nongnu.org, kraxel@redhat.com Date: Tue, 5 Jan 2010 15:27:32 +0900 Message-Id: <1262672870-22607-10-git-send-email-yamahata@valinux.co.jp> X-Mailer: git-send-email 1.6.5.4 In-Reply-To: <1262672870-22607-1-git-send-email-yamahata@valinux.co.jp> References: <1262672870-22607-1-git-send-email-yamahata@valinux.co.jp> X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: yamahata@valinux.co.jp Subject: [Qemu-devel] [PATCH V11 09/27] pc: remove a global variable, floppy_controller. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Remove a global variable, floppy_controller. Since it is unnecessarily global, make it local and pass it as a function argument. Signed-off-by: Isaku Yamahata --- hw/pc.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 0dee9d7..f5eb026 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -64,7 +64,6 @@ #define MAX_IDE_BUS 2 -static fdctrl_t *floppy_controller; static RTCState *rtc_state; typedef struct isa_irq_state { @@ -256,7 +255,8 @@ static int pc_boot_set(void *opaque, const char *boot_device) /* hd_table must contain 4 block drivers */ static void cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_size, - const char *boot_device, DriveInfo **hd_table) + const char *boot_device, DriveInfo **hd_table, + fdctrl_t *floppy_controller) { RTCState *s = rtc_state; int nbds, bds[3] = { 0, }; @@ -1016,6 +1016,7 @@ static void pc_init1(ram_addr_t ram_size, DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; DriveInfo *fd[MAX_FD]; void *fw_cfg; + fdctrl_t *floppy_controller; PITState *pit; if (ram_size >= 0xe0000000 ) { @@ -1226,7 +1227,8 @@ static void pc_init1(ram_addr_t ram_size, } floppy_controller = fdctrl_init_isa(fd); - cmos_init(below_4g_mem_size, above_4g_mem_size, boot_device, hd); + cmos_init(below_4g_mem_size, above_4g_mem_size, boot_device, hd, + floppy_controller); if (pci_enabled && usb_enabled) { usb_uhci_piix3_init(pci_bus, piix3_devfn + 2);