Update timex.h for ADJ_SETOFFSET.
diff mbox

Message ID 1418743574-29087-1-git-send-email-mlichvar@redhat.com
State New
Headers show

Commit Message

Miroslav Lichvar Dec. 16, 2014, 3:26 p.m. UTC
ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
step the clock. It was introduced in kernel 2.6.39.
---
 sysdeps/unix/sysv/linux/bits/timex.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Miroslav Lichvar Jan. 6, 2015, 2:02 p.m. UTC | #1
On Tue, Dec 16, 2014 at 04:26:14PM +0100, Miroslav Lichvar wrote:
> ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
> step the clock. It was introduced in kernel 2.6.39.

Ping? This is a trivial change, useful for NTP and PTP
implementations.

>  #define ADJ_TAI			0x0080	/* set TAI offset */
> +#define ADJ_SETOFFSET		0x0100	/* add 'time' to current time */
>  #define ADJ_MICRO		0x1000	/* select microsecond resolution */
Mike Frysinger Feb. 24, 2015, 5:47 a.m. UTC | #2
On 16 Dec 2014 16:26, Miroslav Lichvar wrote:
> ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
> step the clock. It was introduced in kernel 2.6.39.

OK
-mike
Joseph Myers Feb. 24, 2015, 11:39 a.m. UTC | #3
On Tue, 24 Feb 2015, Mike Frysinger wrote:

> On 16 Dec 2014 16:26, Miroslav Lichvar wrote:
> > ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
> > step the clock. It was introduced in kernel 2.6.39.
> 
> OK

When reviewing patches by people without write access, you need to commit 
the patches for them, not just say "OK".
Mike Frysinger Feb. 24, 2015, 3:34 p.m. UTC | #4
On 24 Feb 2015 11:39, Joseph Myers wrote:
> On Tue, 24 Feb 2015, Mike Frysinger wrote:
> > On 16 Dec 2014 16:26, Miroslav Lichvar wrote:
> > > ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
> > > step the clock. It was introduced in kernel 2.6.39.
> > 
> > OK
> 
> When reviewing patches by people without write access, you need to commit 
> the patches for them, not just say "OK".

i'm aware, but i have no idea who on the list has commit access.  there's too 
many for me to try and remember.  so i just wait for the poster to respond that 
they need assistance.
-mike
Joseph Myers Feb. 24, 2015, 4:16 p.m. UTC | #5
On Tue, 24 Feb 2015, Mike Frysinger wrote:

> On 24 Feb 2015 11:39, Joseph Myers wrote:
> > On Tue, 24 Feb 2015, Mike Frysinger wrote:
> > > On 16 Dec 2014 16:26, Miroslav Lichvar wrote:
> > > > ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
> > > > step the clock. It was introduced in kernel 2.6.39.
> > > 
> > > OK
> > 
> > When reviewing patches by people without write access, you need to commit 
> > the patches for them, not just say "OK".
> 
> i'm aware, but i have no idea who on the list has commit access.  there's too 
> many for me to try and remember.  so i just wait for the poster to respond that 
> they need assistance.

That's the wrong way round.  People without write access also won't know 
that they need to respond like that; you need to avoid assuming such 
knowledge of them.  The MAINTAINERS page on the wiki has a list of people 
with write access.  This applies also to some other recent reviews of 
yours, e.g. <https://sourceware.org/ml/libc-alpha/2015-02/msg00604.html> 
and <https://sourceware.org/ml/libc-alpha/2015-02/msg00649.html>.
Mike Frysinger Feb. 25, 2015, 4:50 a.m. UTC | #6
On 24 Feb 2015 16:16, Joseph Myers wrote:
> The MAINTAINERS page on the wiki has a list of people with write access.

thanks, i didn't realize that page was kept complete/up to date beyond specific 
responsibilities
-mike
Mike Frysinger Feb. 25, 2015, 4:54 a.m. UTC | #7
On 16 Dec 2014 16:26, Miroslav Lichvar wrote:
> ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
> step the clock. It was introduced in kernel 2.6.39.

i've merged this now.  in the future, please include ChangeLog entries in 
your e-mail so we can copy & paste it in.
-mike

Patch
diff mbox

diff --git a/sysdeps/unix/sysv/linux/bits/timex.h b/sysdeps/unix/sysv/linux/bits/timex.h
index ec5b421..c771cd4 100644
--- a/sysdeps/unix/sysv/linux/bits/timex.h
+++ b/sysdeps/unix/sysv/linux/bits/timex.h
@@ -20,7 +20,7 @@ 
 
 #include <bits/types.h>
 
-/* These definitions from linux/timex.h as of 2.6.30.  */
+/* These definitions from linux/timex.h as of 3.18.  */
 
 struct timex
 {
@@ -33,7 +33,7 @@  struct timex
   __syscall_slong_t constant;	/* pll time constant */
   __syscall_slong_t precision;	/* clock precision (usec) (ro) */
   __syscall_slong_t tolerance;	/* clock frequency tolerance (ppm) (ro) */
-  struct timeval time;		/* (read only) */
+  struct timeval time;		/* (read only, except for ADJ_SETOFFSET) */
   __syscall_slong_t tick;	/* (modified) usecs between clock ticks */
   __syscall_slong_t ppsfreq;	/* pps frequency (scaled ppm) (ro) */
   __syscall_slong_t jitter;	/* pps jitter (us) (ro) */
@@ -60,6 +60,7 @@  struct timex
 #define ADJ_STATUS		0x0010	/* clock status */
 #define ADJ_TIMECONST		0x0020	/* pll time constant */
 #define ADJ_TAI			0x0080	/* set TAI offset */
+#define ADJ_SETOFFSET		0x0100	/* add 'time' to current time */
 #define ADJ_MICRO		0x1000	/* select microsecond resolution */
 #define ADJ_NANO		0x2000	/* select nanosecond resolution */
 #define ADJ_TICK		0x4000	/* tick value */