| Message ID | 1418721773-29042-1-git-send-email-arei.gonglei@huawei.com |
|---|---|
| State | New |
| Headers | show |
On 16 December 2014 at 09:22, <arei.gonglei@huawei.com> wrote: > From: root <root@ceth6.(none)> > > This is my first pull request as a submaintainer. Those patches just > move boot order related code to bootdevice.c and add a Error **errp > argument for corresponding functions so that it can propagate error messages > to the caller. Please pull. This also seems to cause 'make check' to fail: TEST: tests/boot-order-test... (pid=16958) /i386/boot-order/pc: Broken pipe FAIL GTester: last random seed: R02S5702c094d31af53e45fffabed844705a (pid=16973) FAIL: tests/boot-order-test thanks -- PMM
On 2014/12/16 22:01, Peter Maydell wrote: > On 16 December 2014 at 09:22, <arei.gonglei@huawei.com> wrote: >> From: root <root@ceth6.(none)> >> >> This is my first pull request as a submaintainer. Those patches just >> move boot order related code to bootdevice.c and add a Error **errp >> argument for corresponding functions so that it can propagate error messages >> to the caller. Please pull. > > This also seems to cause 'make check' to fail: > > TEST: tests/boot-order-test... (pid=16958) > /i386/boot-order/pc: > Broken pipe > FAIL > GTester: last random seed: R02S5702c094d31af53e45fffabed844705a > (pid=16973) > FAIL: tests/boot-order-test > Oops, That's because of a typo in patch 2, 'once' -> 'order'. 'make check' should be executed before posting patches :( I apologize for any inconvenience caused during this process, and great thanks for your precise job. Regards, -Gonglei
From: root <root@ceth6.(none)> This is my first pull request as a submaintainer. Those patches just move boot order related code to bootdevice.c and add a Error **errp argument for corresponding functions so that it can propagate error messages to the caller. Please pull. Regards, -Gonglei The following changes since commit 54600752a1dd67844c2cf3c467db562c39499838: Merge remote-tracking branch 'remotes/rth/tags/x86-next-20141214' into staging (2014-12-15 11:11:52 +0000) are available in the git repository at: https://github.com/gongleiarei/qemu.git tags/bootdevice-next-20141216 for you to fetch changes up to 8bcee1828dd00c03cea03a4fa53e48b58dca49af: bootdevice: add Error **errp argument for QEMUBootSetHandler (2014-12-16 16:52:39 +0800) ---------------------------------------------------------------- bootdevice: refactor and improvement ---------------------------------------------------------------- Gonglei (5): bootdevice: move code about bootorder from vl.c to bootdevice.c bootdevice: add Error **errp argument for validate_bootdevices() bootdevice: add Error **errp argument for qemu_boot_set() bootdevice: add validate check for qemu_boot_set() bootdevice: add Error **errp argument for QEMUBootSetHandler bootdevice.c | 73 ++++++++++++++++++++++++++++++++++++++++++++ hw/i386/pc.c | 21 ++++++------- hw/ppc/mac_newworld.c | 4 +-- hw/ppc/mac_oldworld.c | 5 ++- hw/sparc/sun4m.c | 4 +-- hw/sparc64/sun4u.c | 4 +-- include/hw/hw.h | 6 ---- include/sysemu/sysemu.h | 7 +++++ monitor.c | 14 ++++----- vl.c | 77 ++++++++--------------------------------------- 10 files changed, 116 insertions(+), 99 deletions(-)