From patchwork Tue Jan 5 06:27:47 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [V11,24/27] pc_smbus: remove #ifdef DEBUG. Date: Mon, 04 Jan 2010 20:27:47 -0000 From: Isaku Yamahata X-Patchwork-Id: 42172 Message-Id: <1262672870-22607-25-git-send-email-yamahata@valinux.co.jp> To: qemu-devel@nongnu.org, kraxel@redhat.com Cc: yamahata@valinux.co.jp remove #ifdef DEBUG by using macro. Signed-off-by: Isaku Yamahata --- hw/pc_smbus.c | 21 ++++++++++++--------- 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/pc_smbus.c b/hw/pc_smbus.c index 30cdaa7..1d44d1e 100644 --- a/hw/pc_smbus.c +++ b/hw/pc_smbus.c @@ -37,6 +37,15 @@ #define SMBHSTDAT1 0x06 #define SMBBLKDAT 0x07 +//#define DEBUG + +#ifdef DEBUG +# define SMBUS_DPRINTF(format, ...) printf(format, ## __VA_ARGS__) +#else +# define SMBUS_DPRINTF(format, ...) do { } while (0) +#endif + + static void smb_transaction(PCSMBus *s) { uint8_t prot = (s->smb_ctl >> 2) & 0x07; @@ -45,9 +54,7 @@ static void smb_transaction(PCSMBus *s) uint8_t addr = s->smb_addr >> 1; i2c_bus *bus = s->smbus; -#ifdef DEBUG - printf("SMBus trans addr=0x%02x prot=0x%02x\n", addr, prot); -#endif + SMBUS_DPRINTF("SMBus trans addr=0x%02x prot=0x%02x\n", addr, prot); switch(prot) { case 0x0: smbus_quick_command(bus, addr, read); @@ -96,9 +103,7 @@ void smb_ioport_writeb(void *opaque, uint32_t addr, uint32_t val) { PCSMBus *s = opaque; addr &= 0x3f; -#ifdef DEBUG - printf("SMB writeb port=0x%04x val=0x%02x\n", addr, val); -#endif + SMBUS_DPRINTF("SMB writeb port=0x%04x val=0x%02x\n", addr, val); switch(addr) { case SMBHSTSTS: s->smb_stat = 0; @@ -166,9 +171,7 @@ uint32_t smb_ioport_readb(void *opaque, uint32_t addr) val = 0; break; } -#ifdef DEBUG - printf("SMB readb port=0x%04x val=0x%02x\n", addr, val); -#endif + SMBUS_DPRINTF("SMB readb port=0x%04x val=0x%02x\n", addr, val); return val; }