Patchwork [2/6] mtd: Use get_mtd_device_nm() to find named device in get_sb_mtd()

login
register
mail settings
Submitter Ben Hutchings
Date Jan. 5, 2010, 3:20 p.m.
Message ID <1262704813.2837.7.camel@achroite.uk.solarflarecom.com>
Download mbox | patch
Permalink /patch/42126/
State Accepted
Commit 677c2aec8cdd5ae33b5fab266941cf6c6dc4d59f
Headers show

Comments

Ben Hutchings - Jan. 5, 2010, 3:20 p.m.
This removes the need to know the number of MTD devices.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 drivers/mtd/mtdsuper.c |   18 ++++++------------
 1 files changed, 6 insertions(+), 12 deletions(-)
Artem Bityutskiy - Jan. 10, 2010, 10:21 a.m.
On Tue, 2010-01-05 at 15:20 +0000, Ben Hutchings wrote:
> This removes the need to know the number of MTD devices.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
>  drivers/mtd/mtdsuper.c |   18 ++++++------------
>  1 files changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c
> index af8b42e..d257052 100644
> --- a/drivers/mtd/mtdsuper.c
> +++ b/drivers/mtd/mtdsuper.c
> @@ -150,18 +150,12 @@ int get_sb_mtd(struct file_system_type *fs_type, int flags,
>  			DEBUG(1, "MTDSB: mtd:%%s, name \"%s\"\n",
>  			      dev_name + 4);
>  
> -			for (mtdnr = 0; mtdnr < MAX_MTD_DEVICES; mtdnr++) {
> -				mtd = get_mtd_device(NULL, mtdnr);
> -				if (!IS_ERR(mtd)) {
> -					if (!strcmp(mtd->name, dev_name + 4))
> -						return get_sb_mtd_aux(
> -							fs_type, flags,
> -							dev_name, data, mtd,
> -							fill_super, mnt);
> -
> -					put_mtd_device(mtd);
> -				}
> -			}
> +			mtd = get_mtd_device_nm(dev_name + 4);
> +			if (!IS_ERR(mtd))
> +				return get_sb_mtd_aux(
> +					fs_type, flags,
> +					dev_name, data, mtd,
> +					fill_super, mnt);

Since now your indentation level is less, you could de-uglify the
'get_sb_mtd_aux()' as well, while you are on it. But this is minor.
Artem Bityutskiy - Jan. 10, 2010, 10:35 a.m.
On Tue, 2010-01-05 at 15:20 +0000, Ben Hutchings wrote:
> This removes the need to know the number of MTD devices.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
>  drivers/mtd/mtdsuper.c |   18 ++++++------------
>  1 files changed, 6 insertions(+), 12 deletions(-)

Reviewed-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Patch

diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c
index af8b42e..d257052 100644
--- a/drivers/mtd/mtdsuper.c
+++ b/drivers/mtd/mtdsuper.c
@@ -150,18 +150,12 @@  int get_sb_mtd(struct file_system_type *fs_type, int flags,
 			DEBUG(1, "MTDSB: mtd:%%s, name \"%s\"\n",
 			      dev_name + 4);
 
-			for (mtdnr = 0; mtdnr < MAX_MTD_DEVICES; mtdnr++) {
-				mtd = get_mtd_device(NULL, mtdnr);
-				if (!IS_ERR(mtd)) {
-					if (!strcmp(mtd->name, dev_name + 4))
-						return get_sb_mtd_aux(
-							fs_type, flags,
-							dev_name, data, mtd,
-							fill_super, mnt);
-
-					put_mtd_device(mtd);
-				}
-			}
+			mtd = get_mtd_device_nm(dev_name + 4);
+			if (!IS_ERR(mtd))
+				return get_sb_mtd_aux(
+					fs_type, flags,
+					dev_name, data, mtd,
+					fill_super, mnt);
 
 			printk(KERN_NOTICE "MTD:"
 			       " MTD device with name \"%s\" not found.\n",