From patchwork Tue Jan 5 11:16:50 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 42112 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C6911B6EF2 for ; Tue, 5 Jan 2010 22:16:59 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751826Ab0AELQy (ORCPT ); Tue, 5 Jan 2010 06:16:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751480Ab0AELQy (ORCPT ); Tue, 5 Jan 2010 06:16:54 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:43918 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751234Ab0AELQx (ORCPT ); Tue, 5 Jan 2010 06:16:53 -0500 Received: from rakim.wolfsonmicro.main (lumison.wolfsonmicro.com [87.246.78.27]) by opensource2.wolfsonmicro.com (Postfix) with ESMTPSA id D524376970B; Tue, 5 Jan 2010 11:16:51 +0000 (GMT) Received: from broonie by rakim.wolfsonmicro.main with local (Exim 4.71) (envelope-from ) id 1NS7P9-0005PQ-2A; Tue, 05 Jan 2010 11:16:51 +0000 From: Mark Brown To: "David S. Miller" Cc: netdev@vger.kernel.org, Mark Brown Subject: [PATCH] cs89x0: Always report failure to request interrupt Date: Tue, 5 Jan 2010 11:16:50 +0000 Message-Id: <1262690210-20763-1-git-send-email-broonie@opensource.wolfsonmicro.com> X-Mailer: git-send-email 1.6.5.7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A failure on request_irq() is always fatal but unlike other fatal errors it's only reported to the user if net_debug is set. Make the diagnostic unconditional and raise the priority so that errors are more obvious to the user. Signed-off-by: Mark Brown --- drivers/net/cs89x0.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c index 5598677..9b5bbc6 100644 --- a/drivers/net/cs89x0.c +++ b/drivers/net/cs89x0.c @@ -1325,8 +1325,7 @@ net_open(struct net_device *dev) write_irq(dev, lp->chip_type, dev->irq); ret = request_irq(dev->irq, net_interrupt, 0, dev->name, dev); if (ret) { - if (net_debug) - printk(KERN_DEBUG "cs89x0: request_irq(%d) failed\n", dev->irq); + printk(KERN_ERR "cs89x0: request_irq(%d) failed\n", dev->irq); goto bad_out; } }