| Message ID | 1418398967-2183-4-git-send-email-gregd72002@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Gregory Dymarek,
On Fri, 12 Dec 2014 15:42:43 +0000, Gregory Dymarek wrote:
> Signed-off-by: Gregory Dymarek <gregd72002@gmail.com>
Thanks, I've applied your patch, but after doing a fairly significant
set of changes. As detailed in the commit log:
[Thomas:
- Rename patch to the proper naming convention
- Reduce patch to only take care of the IPv6 case
- Add description in the patch
- Propagate libglib2 dependencies in Config.in + added the
corresponding comment.
- Added a real help text, and fixed the help text indentation.
- Fixed the comment header in the .mk file to have the right number
of # signs.
- Added the license informations
- Added a dependency on host-pkgconf, used by the configure script
- Added --without-gstreamer and --without-gstreamer-0.10 to be
explicit about the fact that we don't support GStreamer in libnice
for now.
- Fixed the hash file to have the proper format.]
See http://git.buildroot.net/buildroot/commit/?id=89502b9d56ad4f06954fae55684ef21525ad2515.
May I suggest you to compare the final commit and your original patch,
so that you can see what the issues were, for your upcoming
contributions?
Thanks a lot!
Thomas Petazzoni
diff --git a/package/Config.in b/package/Config.in index 49fb8b3..e8c973e 100644 --- a/package/Config.in +++ b/package/Config.in @@ -824,6 +824,7 @@ menu "Networking" source "package/libmnl/Config.in" source "package/libmodbus/Config.in" source "package/libndp/Config.in" + source "package/libnice/Config.in" source "package/libnetfilter_acct/Config.in" source "package/libnetfilter_conntrack/Config.in" source "package/libnetfilter_cthelper/Config.in" diff --git a/package/libnice/Config.in b/package/libnice/Config.in new file mode 100644 index 0000000..1ff8560 --- /dev/null +++ b/package/libnice/Config.in @@ -0,0 +1,6 @@ +config BR2_PACKAGE_LIBNICE + bool "libnice" + select BR2_PACKAGE_LIBGLIB2 + help + Adds libnice - The GLib ICE implementation + http://nice.freedesktop.org/wiki/ diff --git a/package/libnice/libnice-0001-build-IPV6_RECVERR.patch b/package/libnice/libnice-0001-build-IPV6_RECVERR.patch new file mode 100644 index 0000000..39ef617 --- /dev/null +++ b/package/libnice/libnice-0001-build-IPV6_RECVERR.patch @@ -0,0 +1,20 @@ +diff -rupN libnice-0.1.8.orig/stun/usages/bind.c libnice-0.1.8/stun/usages/bind.c +--- libnice-0.1.8.orig/stun/usages/bind.c 2014-09-22 18:01:28.000000000 +0100 ++++ libnice-0.1.8/stun/usages/bind.c 2014-12-01 13:28:32.144707407 +0000 +@@ -257,12 +257,16 @@ static int stun_socket (int family, int + int yes = 1; + switch (family) + { ++#ifdef IP_RECVERR + case AF_INET: + setsockopt (fd, SOL_IP, IP_RECVERR, &yes, sizeof (yes)); ++#endif + break; ++#ifdef IPV6_RECVERR + case AF_INET6: + setsockopt (fd, SOL_IPV6, IPV6_RECVERR, &yes, sizeof (yes)); + break; ++#endif + default: + /* Nothing to do. */ + break; diff --git a/package/libnice/libnice.hash b/package/libnice/libnice.hash new file mode 100644 index 0000000..39f15d9 --- /dev/null +++ b/package/libnice/libnice.hash @@ -0,0 +1 @@ +sha256,9da7f09909902d535389d929c3e4d69129528fb18438a6c8565ec812d9904ddf diff --git a/package/libnice/libnice.mk b/package/libnice/libnice.mk new file mode 100644 index 0000000..dd7f7a4 --- /dev/null +++ b/package/libnice/libnice.mk @@ -0,0 +1,11 @@ +############################################################# +# +# libnice +# +############################################################# +LIBNICE_VERSION = 0.1.8 +LIBNICE_SITE = http://nice.freedesktop.org/releases/ +LIBNICE_DEPENDENCIES = libglib2 +LIBNICE_INSTALL_STAGING = YES + +$(eval $(autotools-package))
Signed-off-by: Gregory Dymarek <gregd72002@gmail.com> --- package/Config.in | 1 + package/libnice/Config.in | 6 ++++++ .../libnice/libnice-0001-build-IPV6_RECVERR.patch | 20 ++++++++++++++++++++ package/libnice/libnice.hash | 1 + package/libnice/libnice.mk | 11 +++++++++++ 5 files changed, 39 insertions(+) create mode 100644 package/libnice/Config.in create mode 100644 package/libnice/libnice-0001-build-IPV6_RECVERR.patch create mode 100644 package/libnice/libnice.hash create mode 100644 package/libnice/libnice.mk