Patchwork ide-tape: panic when probing device at boot

mail settings
Submitter Borislav Petkov
Date Jan. 4, 2010, 5:47 a.m.
Message ID <20100104054740.GA10094@liondog.tnic>
Download mbox | patch
Permalink /patch/42042/
State RFC
Delegated to: David Miller
Headers show


Borislav Petkov - Jan. 4, 2010, 5:47 a.m.
On Mon, Jan 04, 2010 at 11:45:12AM +1030, Jonathan Woithe wrote:
> Has there been any movement on this in recent months?  I gave 2.6.30 a whirl
> on the machine when that was released but it still gave major problems with
> the ide-tape driver.  Is 2.6.32 likely to be improved?  If so I'll make
> arrangements to test that version.

Yes, please do test 2.6.32 to see whether it fixes your problem. If you still
get that oops, please apply the following patch and send me the _whole_ dmesg
output of the machine.




diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 6a0e625..e4c3ffd 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -49,7 +49,7 @@ 
 #include <linux/mtio.h>
 /* define to see debug info */
 #define ide_debug_log(lvl, fmt, args...) __ide_debug_log(lvl, fmt, ## args)
@@ -1737,6 +1737,8 @@  static void idetape_setup(ide_drive_t *drive, idetape_tape_t *tape, int minor)
 	int buffer_size;
 	u16 *ctl = (u16 *)&tape->caps[12];
+	drive->debug_mask = 0xffffffff;
 	ide_debug_log(IDE_DBG_FUNC, "minor: %d", minor);
 	drive->pc_callback = ide_tape_callback;