Patchwork [4/4] MTD: include ar7part in the list of partitions parsers

login
register
mail settings
Submitter Florian Fainelli
Date Jan. 3, 2010, 8:17 p.m.
Message ID <201001032117.37459.florian@openwrt.org>
Download mbox | patch
Permalink /patch/42038/
State New
Headers show

Comments

Florian Fainelli - Jan. 3, 2010, 8:17 p.m.
This patch modifies the physmap-flash driver to include
the ar7part partition parser in the list of parsers to
use when a physmap-flash driver is registered. This is
required for AR7 to create partitions correctly.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
David Woodhouse - Jan. 3, 2010, 8:56 p.m.
On Sun, 2010-01-03 at 21:17 +0100, Florian Fainelli wrote:
> This patch modifies the physmap-flash driver to include
> the ar7part partition parser in the list of parsers to
> use when a physmap-flash driver is registered. This is
> required for AR7 to create partitions correctly.

Hrm, perhaps we'd do better to allow the probe types to be specified in
the platform physmap_flash_data?
Florian Fainelli - Jan. 4, 2010, 7:09 a.m.
Hi David,

Le dimanche 3 janvier 2010 21:56:17, David Woodhouse a écrit :
> On Sun, 2010-01-03 at 21:17 +0100, Florian Fainelli wrote:
> > This patch modifies the physmap-flash driver to include
> > the ar7part partition parser in the list of parsers to
> > use when a physmap-flash driver is registered. This is
> > required for AR7 to create partitions correctly.
> 
> Hrm, perhaps we'd do better to allow the probe types to be specified in
> the platform physmap_flash_data?

I guess so, will cook a patch which does that. Thanks!
Artem Bityutskiy - Jan. 10, 2010, 9:11 a.m.
On Sun, 2010-01-03 at 21:17 +0100, Florian Fainelli wrote:
> This patch modifies the physmap-flash driver to include
> the ar7part partition parser in the list of parsers to
> use when a physmap-flash driver is registered. This is
> required for AR7 to create partitions correctly.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>

Taken this to my l2-mtd-2.6/dunno tree.
Artem Bityutskiy - Jan. 10, 2010, 9:13 a.m.
On Sun, 2010-01-10 at 11:11 +0200, Artem Bityutskiy wrote:
> On Sun, 2010-01-03 at 21:17 +0100, Florian Fainelli wrote:
> > This patch modifies the physmap-flash driver to include
> > the ar7part partition parser in the list of parsers to
> > use when a physmap-flash driver is registered. This is
> > required for AR7 to create partitions correctly.
> > 
> > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> 
> Taken this to my l2-mtd-2.6/dunno tree.

And removed after looking at the discussion :-)

Patch

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index d9603f7..0e65ee7 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -79,7 +79,7 @@  static const char *rom_probe_types[] = {
 					"map_rom",
 					NULL };
 #ifdef CONFIG_MTD_PARTITIONS
-static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL };
+static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", "ar7part", NULL };
 #endif
 
 static int physmap_flash_probe(struct platform_device *dev)