| Message ID | 1418354647-6306-1-git-send-email-acelan.kao@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Dec 12, 2014 at 11:24:07AM +0800, AceLan Kao wrote: > BugLink: http://bugs.launchpad.net/bugs/1359010 > > SRU Justification: > > Impact: The ACPI video backlight interface is broken under WIN8 OSI, > have to switch to use native backlight interface. > > Fix: Add this machine into quirk to force it use native backlight interface > > Testcase: Tested on HP ProBook 6570b laptop > > The quirk mechanism has been remove since v3.18-rc1 > e4d38b5 ACPI / video: Remove video_set_use_native_backlight quirk > After this commit which is in 3.17-rc4, it will use native backlight as default > 25294e9 ACPI / video: Fix use_native_backlight selection logic > So, we can't upstream this patch, and we also need it in vivid. Vivid will be v3.18+ very soon, and from what I can see it will have no need of this quirk, as the default is now on. > Signed-off-by: AceLan Kao <acelan.kao@canonical.com> > --- > drivers/acpi/video.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > index e858463..db1dccd 100644 > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -604,6 +604,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"), > }, > }, > + { > + .callback = video_set_use_native_backlight, > + .ident = "HP ProBook 6570b", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook 6570b"), > + }, > + }, > {} > }; > Acked-by: Andy Whitcroft <apw@canonical.com> -apw
On 12/11/2014 09:24 PM, AceLan Kao wrote: > BugLink: http://bugs.launchpad.net/bugs/1359010 > > SRU Justification: > > Impact: The ACPI video backlight interface is broken under WIN8 OSI, > have to switch to use native backlight interface. > > Fix: Add this machine into quirk to force it use native backlight interface > > Testcase: Tested on HP ProBook 6570b laptop > > The quirk mechanism has been remove since v3.18-rc1 > e4d38b5 ACPI / video: Remove video_set_use_native_backlight quirk > After this commit which is in 3.17-rc4, it will use native backlight as default > 25294e9 ACPI / video: Fix use_native_backlight selection logic > So, we can't upstream this patch, and we also need it in vivid. > > Signed-off-by: AceLan Kao <acelan.kao@canonical.com> > --- > drivers/acpi/video.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > index e858463..db1dccd 100644 > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -604,6 +604,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"), > }, > }, > + { > + .callback = video_set_use_native_backlight, > + .ident = "HP ProBook 6570b", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook 6570b"), > + }, > + }, > {} > }; > >
Applied to Trusty and Utopic. -apw
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index e858463..db1dccd 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -604,6 +604,14 @@ static struct dmi_system_id video_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"), }, }, + { + .callback = video_set_use_native_backlight, + .ident = "HP ProBook 6570b", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook 6570b"), + }, + }, {} };
BugLink: http://bugs.launchpad.net/bugs/1359010 SRU Justification: Impact: The ACPI video backlight interface is broken under WIN8 OSI, have to switch to use native backlight interface. Fix: Add this machine into quirk to force it use native backlight interface Testcase: Tested on HP ProBook 6570b laptop The quirk mechanism has been remove since v3.18-rc1 e4d38b5 ACPI / video: Remove video_set_use_native_backlight quirk After this commit which is in 3.17-rc4, it will use native backlight as default 25294e9 ACPI / video: Fix use_native_backlight selection logic So, we can't upstream this patch, and we also need it in vivid. Signed-off-by: AceLan Kao <acelan.kao@canonical.com> --- drivers/acpi/video.c | 8 ++++++++ 1 file changed, 8 insertions(+)