diff mbox

[2/3] iprutils: Don't include host headers

Message ID 1418340467-29999-2-git-send-email-romain.naour@openwide.fr
State Superseded
Headers show

Commit Message

Romain Naour Dec. 11, 2014, 11:27 p.m. UTC
Fixes:
ERROR: unsafe header/library path used in cross-compilation: '/usr/include/ncurses'

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/iprutils/iprutils.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Dec. 12, 2014, 8:58 a.m. UTC | #1
Dear Romain Naour,

On Fri, 12 Dec 2014 00:27:46 +0100, Romain Naour wrote:
> Fixes:
> ERROR: unsafe header/library path used in cross-compilation: '/usr/include/ncurses'
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/iprutils/iprutils.mk | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/iprutils/iprutils.mk b/package/iprutils/iprutils.mk
> index 53516b6..0721fbf 100644
> --- a/package/iprutils/iprutils.mk
> +++ b/package/iprutils/iprutils.mk
> @@ -12,11 +12,14 @@ IPRUTILS_LICENSE = Common Public License Version 1.0
>  IPRUTILS_LICENSE_FILES = LICENSE
>  
>  define IPRUTILS_BUILD_CMDS
> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) \
> +		INCLUDEDIR="-I. -I$(STAGING_DIR)/usr/include/ncurses" \
> +		-C $(@D) all

Thanks. Shouldn't we instead patch the Makefile itself, and submit the
change upstream?

Thanks,

Thomas
Romain Naour Dec. 12, 2014, 11:28 p.m. UTC | #2
Hi Thomas,

Le 12/12/2014 09:58, Thomas Petazzoni a écrit :
> Dear Romain Naour,
> 
> On Fri, 12 Dec 2014 00:27:46 +0100, Romain Naour wrote:
>> Fixes:
>> ERROR: unsafe header/library path used in cross-compilation: '/usr/include/ncurses'
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>>  package/iprutils/iprutils.mk | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/iprutils/iprutils.mk b/package/iprutils/iprutils.mk
>> index 53516b6..0721fbf 100644
>> --- a/package/iprutils/iprutils.mk
>> +++ b/package/iprutils/iprutils.mk
>> @@ -12,11 +12,14 @@ IPRUTILS_LICENSE = Common Public License Version 1.0
>>  IPRUTILS_LICENSE_FILES = LICENSE
>>  
>>  define IPRUTILS_BUILD_CMDS
>> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
>> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) \
>> +		INCLUDEDIR="-I. -I$(STAGING_DIR)/usr/include/ncurses" \
>> +		-C $(@D) all
> 
> Thanks. Shouldn't we instead patch the Makefile itself, and submit the
> change upstream?
> 

It seems that Viencent's patches are not yet commited in iprutils.
So, I'll push all patches to my sourceforge account and post a message
in the forum.

Best regards,
Romain Naour
diff mbox

Patch

diff --git a/package/iprutils/iprutils.mk b/package/iprutils/iprutils.mk
index 53516b6..0721fbf 100644
--- a/package/iprutils/iprutils.mk
+++ b/package/iprutils/iprutils.mk
@@ -12,11 +12,14 @@  IPRUTILS_LICENSE = Common Public License Version 1.0
 IPRUTILS_LICENSE_FILES = LICENSE
 
 define IPRUTILS_BUILD_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) \
+		INCLUDEDIR="-I. -I$(STAGING_DIR)/usr/include/ncurses" \
+		-C $(@D) all
 endef
 
 define IPRUTILS_INSTALL_TARGET_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) INSTALL_MOD_PATH=$(TARGET_DIR) -C $(@D) install
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) INSTALL_MOD_PATH=$(TARGET_DIR) \
+		-C $(@D) install
 endef
 
 $(eval $(generic-package))