From patchwork Thu Dec 11 22:38:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 420270 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 840091400DE for ; Fri, 12 Dec 2014 09:38:39 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=VSP8r e8JC2VXuw9aenpxw1zsd153nGIic/tG4E/ktv5pTPo9fFl805l3P+x0KXAm9gVJ+ 1cNwMUbeAzSR8lHFkRGyqG0V5mk2mLkcH9qYNb4xIm+IZVGoYtaMb+gVsJ63OS+R 4w+FuVziKouCwDR9PLVHlSTugmQv/OiCYfvZ14= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=9nI0SMwGkGw EHXpFolFmhMwZZqc=; b=M5ScpUAf8Diwgp6n/a2Oc+T3rZz8s071PP5HCsRzGT+ mT849L9eXnqH91o5fJGG6DJDjiUtlOAfikp4kkoVhko/nManiGVjPNGilslNuCH6 QVxI2vijPcpOR4b8jya3Xig4TMFVsf/9Lq+VPNJLFibDrunNmNyjL++FEFJ39CaI = Received: (qmail 6800 invoked by alias); 11 Dec 2014 22:38:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 6786 invoked by uid 89); 11 Dec 2014 22:38:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Thu, 11 Dec 2014 22:38:21 +0000 From: Joseph Myers To: Roland McGrath CC: Subject: Re: Ping^2 Re: Add more headers to include/ for conform tests In-Reply-To: <20141211190100.EF8852C3ACD@topped-with-meat.com> Message-ID: References: <20141211190100.EF8852C3ACD@topped-with-meat.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 On Thu, 11 Dec 2014, Roland McGrath wrote: > I think moving semaphore.h to sysdeps/pthread/ is sound. This patch does that move. (I left the Makefile setting to install this header in nptl/, but maybe it should move as well - it's just not clear to me what ifeq ($(subdir),...) conditional should be used to select the directory to associate the header with for installation purposes. The path in the toplevel Makefile used for begin-end-check also remains hardcoded; it's a known todo issue to rework that test to run in each subdirectory checking the headers installed from that subdirectory, rather than a separate hardcoded list.) Tested for x86_64 (testsuite, and that installed stripped shared libraries are unchanged by the patch). I did *not* test a configuration such as that in which Carlos saw failure. 2014-12-11 Joseph Myers * nptl/semaphore.h: Move to ... * sysdeps/pthread/semaphore.h: ... here. * Makefile (installed-headers): Change nptl/semaphore.h to sysdeps/pthread/semaphore.h. diff --git a/Makefile b/Makefile index 51ff5ca..b012ced 100644 --- a/Makefile +++ b/Makefile @@ -284,7 +284,7 @@ installed-headers = argp/argp.h assert/assert.h catgets/nl_types.h \ malloc/obstack.h malloc/mcheck.h math/math.h \ math/complex.h math/fenv.h math/tgmath.h misc/sys/uio.h \ $(wildcard nis/rpcsvc/*.h) nptl_db/thread_db.h \ - sysdeps/nptl/pthread.h nptl/semaphore.h \ + sysdeps/nptl/pthread.h sysdeps/pthread/semaphore.h \ nss/nss.h posix/sys/utsname.h posix/sys/times.h \ posix/sys/wait.h posix/sys/types.h posix/unistd.h \ posix/glob.h posix/regex.h posix/wordexp.h posix/fnmatch.h\ diff --git a/nptl/semaphore.h b/sysdeps/pthread/semaphore.h similarity index 100% rename from nptl/semaphore.h rename to sysdeps/pthread/semaphore.h