From patchwork Sat Jan 2 03:45:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 41998 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 99758B6EEE for ; Sat, 2 Jan 2010 14:57:17 +1100 (EST) Received: from localhost ([127.0.0.1]:53752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQv74-00020I-JF for incoming@patchwork.ozlabs.org; Fri, 01 Jan 2010 22:57:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQuw7-0006ZU-4z for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQuw1-0006Wq-TO for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:53 -0500 Received: from [199.232.76.173] (port=53813 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQuw1-0006Wa-EL for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:49 -0500 Received: from mail-fx0-f222.google.com ([209.85.220.222]:63383) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NQuw1-00082k-6P for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:49 -0500 Received: by mail-fx0-f222.google.com with SMTP id 22so16659819fxm.2 for ; Fri, 01 Jan 2010 19:45:48 -0800 (PST) Received: by 10.223.102.130 with SMTP id g2mr3692380fao.52.1262403948693; Fri, 01 Jan 2010 19:45:48 -0800 (PST) Received: from localhost.localdomain (a88-114-220-92.elisa-laajakaista.fi [88.114.220.92]) by mx.google.com with ESMTPS id 35sm22820386fkt.40.2010.01.01.19.45.47 (version=SSLv3 cipher=RC4-MD5); Fri, 01 Jan 2010 19:45:47 -0800 (PST) From: "Kirill A. Shutemov" To: qemu-devel@nongnu.org Date: Sat, 2 Jan 2010 05:45:26 +0200 Message-Id: <1262403933-26881-8-git-send-email-kirill@shutemov.name> X-Mailer: git-send-email 1.6.5.7 In-Reply-To: <1262403933-26881-7-git-send-email-kirill@shutemov.name> References: <1262403933-26881-1-git-send-email-kirill@shutemov.name> <1262403933-26881-2-git-send-email-kirill@shutemov.name> <1262403933-26881-3-git-send-email-kirill@shutemov.name> <1262403933-26881-4-git-send-email-kirill@shutemov.name> <1262403933-26881-5-git-send-email-kirill@shutemov.name> <1262403933-26881-6-git-send-email-kirill@shutemov.name> <1262403933-26881-7-git-send-email-kirill@shutemov.name> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: "Kirill A. Shutemov" Subject: [Qemu-devel] [PATCH 08/15] net/slirp.c: fix warning with _FORTIFY_SOURCE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org CC net/slirp.o cc1: warnings being treated as errors net/slirp.c: In function 'slirp_smb_cleanup': net/slirp.c:470: error: ignoring return value of 'system', declared with attribute warn_unused_result make: *** [net/slirp.o] Error 1 Signed-off-by: Kirill A. Shutemov --- net/slirp.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 3f91c4b..ef7c8e4 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -464,10 +464,17 @@ int net_slirp_redir(const char *redir_str) static void slirp_smb_cleanup(SlirpState *s) { char cmd[128]; + int ret; if (s->smb_dir[0] != '\0') { snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir); - system(cmd); + ret = system(cmd); + if (ret == -1) { + perror("system()"); + } else if (WEXITSTATUS(ret)) { + qemu_error("'%s' failed. Error code: %d\n", + cmd, WEXITSTATUS(ret)); + } s->smb_dir[0] = '\0'; } }