From patchwork Sat Jan 2 03:45:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [06/15] block/vvfat.c: fix warnings with _FORTIFY_SOURCE From: "Kirill A. Shutemov" X-Patchwork-Id: 41996 Message-Id: <1262403933-26881-6-git-send-email-kirill@shutemov.name> To: qemu-devel@nongnu.org Cc: "Kirill A. Shutemov" Date: Sat, 2 Jan 2010 05:45:24 +0200 CC block/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CC block/vvfat.o In file included from /usr/include/stdio.h:912, from ./qemu-common.h:19, from block/vvfat.c:27: In function 'snprintf', inlined from 'init_directories' at block/vvfat.c:871, inlined from 'vvfat_open' at block/vvfat.c:1068: /usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will always overflow destination buffer make: *** [block/vvfat.o] Error 1 Signed-off-by: Kirill A. Shutemov --- block/vvfat.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 063f731..8140dbc 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -868,7 +868,7 @@ static int init_directories(BDRVVVFATState* s, { direntry_t* entry=array_get_next(&(s->directory)); entry->attributes=0x28; /* archive | volume label */ - snprintf((char*)entry->name,11,"QEMU VVFAT"); + memcpy(entry->name, "QEMU VVFAT", 11); } /* Now build FAT, and write back information into directory */ @@ -2256,7 +2256,10 @@ static int commit_one_file(BDRVVVFATState* s, c = c1; } - ftruncate(fd, size); + if (ftruncate(fd, size)) { + perror("ftruncate()"); + abort(); + } close(fd); return commit_mappings(s, first_cluster, dir_index);