From patchwork Sat Jan 2 03:45:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 41996 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E473EB6EEE for ; Sat, 2 Jan 2010 14:54:01 +1100 (EST) Received: from localhost ([127.0.0.1]:44793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQv3v-0000iD-BA for incoming@patchwork.ozlabs.org; Fri, 01 Jan 2010 22:53:59 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQuw3-0006Xc-GX for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQuvy-0006V1-LN for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:51 -0500 Received: from [199.232.76.173] (port=53811 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQuvy-0006Uw-DR for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:46 -0500 Received: from mail-fx0-f222.google.com ([209.85.220.222]:63383) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NQuvy-00082k-5c for qemu-devel@nongnu.org; Fri, 01 Jan 2010 22:45:46 -0500 Received: by mail-fx0-f222.google.com with SMTP id 22so16659819fxm.2 for ; Fri, 01 Jan 2010 19:45:45 -0800 (PST) Received: by 10.223.4.193 with SMTP id 1mr5583022fas.12.1262403945529; Fri, 01 Jan 2010 19:45:45 -0800 (PST) Received: from localhost.localdomain (a88-114-220-92.elisa-laajakaista.fi [88.114.220.92]) by mx.google.com with ESMTPS id 35sm22820386fkt.40.2010.01.01.19.45.43 (version=SSLv3 cipher=RC4-MD5); Fri, 01 Jan 2010 19:45:44 -0800 (PST) From: "Kirill A. Shutemov" To: qemu-devel@nongnu.org Date: Sat, 2 Jan 2010 05:45:24 +0200 Message-Id: <1262403933-26881-6-git-send-email-kirill@shutemov.name> X-Mailer: git-send-email 1.6.5.7 In-Reply-To: <1262403933-26881-5-git-send-email-kirill@shutemov.name> References: <1262403933-26881-1-git-send-email-kirill@shutemov.name> <1262403933-26881-2-git-send-email-kirill@shutemov.name> <1262403933-26881-3-git-send-email-kirill@shutemov.name> <1262403933-26881-4-git-send-email-kirill@shutemov.name> <1262403933-26881-5-git-send-email-kirill@shutemov.name> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: "Kirill A. Shutemov" Subject: [Qemu-devel] [PATCH 06/15] block/vvfat.c: fix warnings with _FORTIFY_SOURCE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org CC block/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CC block/vvfat.o In file included from /usr/include/stdio.h:912, from ./qemu-common.h:19, from block/vvfat.c:27: In function 'snprintf', inlined from 'init_directories' at block/vvfat.c:871, inlined from 'vvfat_open' at block/vvfat.c:1068: /usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will always overflow destination buffer make: *** [block/vvfat.o] Error 1 Signed-off-by: Kirill A. Shutemov --- block/vvfat.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 063f731..8140dbc 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -868,7 +868,7 @@ static int init_directories(BDRVVVFATState* s, { direntry_t* entry=array_get_next(&(s->directory)); entry->attributes=0x28; /* archive | volume label */ - snprintf((char*)entry->name,11,"QEMU VVFAT"); + memcpy(entry->name, "QEMU VVFAT", 11); } /* Now build FAT, and write back information into directory */ @@ -2256,7 +2256,10 @@ static int commit_one_file(BDRVVVFATState* s, c = c1; } - ftruncate(fd, size); + if (ftruncate(fd, size)) { + perror("ftruncate()"); + abort(); + } close(fd); return commit_mappings(s, first_cluster, dir_index);