Patchwork iproute2: avoid using bashisms in configure script.

login
register
mail settings
Submitter Andreas Henriksson
Date Jan. 1, 2010, 10:20 p.m.
Message ID <20100101222030.GA12149@amd64.fatal.se>
Download mbox | patch
Permalink /patch/41990/
State Accepted
Delegated to: stephen hemminger
Headers show

Comments

Andreas Henriksson - Jan. 1, 2010, 10:20 p.m.
"function foo" should be "foo()" to work when sh is not bash.

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---

Sorry for not getting this right the first time around....

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
stephen hemminger - Jan. 21, 2010, 6:09 p.m.
On Fri, 1 Jan 2010 23:20:30 +0100
Andreas Henriksson <andreas@fatal.se> wrote:

> "function foo" should be "foo()" to work when sh is not bash.
> 
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
> ---

applied, 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/configure
+++ b/configure
@@ -3,7 +3,7 @@ 
 #
 INCLUDE=${1:-"$PWD/include"}
 
-function check_atm
+check_atm()
 {
 cat >/tmp/atmtest.c <<EOF
 #include <atm.h>
@@ -24,7 +24,7 @@  fi
 rm -f /tmp/atmtest.c /tmp/atmtest
 }
 
-function check_xt
+check_xt()
 {
 #check if we have xtables from iptables >= 1.4.5.
 cat >/tmp/ipttest.c <<EOF
@@ -55,7 +55,7 @@  fi
 rm -f /tmp/ipttest.c /tmp/ipttest
 }
 
-function check_xt_old
+check_xt_old()
 {
 # bail if previous XT checks has already succeded.
 if grep TC_CONFIG_XT Config > /dev/null
@@ -94,7 +94,7 @@  fi
 rm -f /tmp/ipttest.c /tmp/ipttest
 }
 
-function check_xt_old_internal_h
+check_xt_old_internal_h()
 {
 # bail if previous XT checks has already succeded.
 if grep TC_CONFIG_XT Config > /dev/null
@@ -134,7 +134,7 @@  fi
 rm -f /tmp/ipttest.c /tmp/ipttest
 }
 
-function check_ipt
+check_ipt()
 {
 	if ! grep TC_CONFIG_XT Config > /dev/null
 	then