| Message ID | 1418215892-17617-4-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
Hi Bin, On 10 December 2014 at 18:21, Bin Meng <bmeng.cn@gmail.com> wrote: > Update supported read commands for EON flash parts to RD_EXTN and > QUAD_IO_FAST per datasheet. Also update flash sector size to 4KiB > as long as flash supports sector erase (20h) command. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > drivers/mtd/spi/sf_params.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c > index cc4cd60..3e5c6e0 100644 > --- a/drivers/mtd/spi/sf_params.c > +++ b/drivers/mtd/spi/sf_params.c > @@ -26,10 +26,10 @@ const struct spi_flash_params spi_flash_params_table[] = { > {"AT25DF321A", 0x1f4701, 0x0, 4 * 1024, 1024, RD_NORM, SECT_4K}, > #endif > #ifdef CONFIG_SPI_FLASH_EON /* EON */ > - {"EN25Q32B", 0x1c3016, 0x0, 64 * 1024, 64, RD_NORM, 0}, > - {"EN25Q64", 0x1c3017, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K}, > - {"EN25Q128B", 0x1c3018, 0x0, 64 * 1024, 256, RD_NORM, 0}, > - {"EN25S64", 0x1c3817, 0x0, 64 * 1024, 128, RD_NORM, 0}, > + {"EN25Q32B", 0x1c3016, 0x0, 4 * 1024, 1024, RD_EXTN | QUAD_IO_FAST, SECT_4K}, > + {"EN25Q64", 0x1c3017, 0x0, 4 * 1024, 2048, RD_EXTN | QUAD_IO_FAST, SECT_4K}, > + {"EN25Q128B", 0x1c3018, 0x0, 4 * 1024, 4096, RD_EXTN | QUAD_IO_FAST, SECT_4K}, > + {"EN25S64", 0x1c3817, 0x0, 4 * 1024, 2048, RD_EXTN | QUAD_IO_FAST, SECT_4K}, Did you test this QUAD_IO_FAST ? > #endif > #ifdef CONFIG_SPI_FLASH_GIGADEVICE /* GIGADEVICE */ > {"GD25Q64B", 0xc84017, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K}, > -- > 1.8.2.1 > thanks!
Hi Jagan, On Thu, Dec 11, 2014 at 2:31 AM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > Hi Bin, > > On 10 December 2014 at 18:21, Bin Meng <bmeng.cn@gmail.com> wrote: >> Update supported read commands for EON flash parts to RD_EXTN and >> QUAD_IO_FAST per datasheet. Also update flash sector size to 4KiB >> as long as flash supports sector erase (20h) command. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> drivers/mtd/spi/sf_params.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c >> index cc4cd60..3e5c6e0 100644 >> --- a/drivers/mtd/spi/sf_params.c >> +++ b/drivers/mtd/spi/sf_params.c >> @@ -26,10 +26,10 @@ const struct spi_flash_params spi_flash_params_table[] = { >> {"AT25DF321A", 0x1f4701, 0x0, 4 * 1024, 1024, RD_NORM, SECT_4K}, >> #endif >> #ifdef CONFIG_SPI_FLASH_EON /* EON */ >> - {"EN25Q32B", 0x1c3016, 0x0, 64 * 1024, 64, RD_NORM, 0}, >> - {"EN25Q64", 0x1c3017, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K}, >> - {"EN25Q128B", 0x1c3018, 0x0, 64 * 1024, 256, RD_NORM, 0}, >> - {"EN25S64", 0x1c3817, 0x0, 64 * 1024, 128, RD_NORM, 0}, >> + {"EN25Q32B", 0x1c3016, 0x0, 4 * 1024, 1024, RD_EXTN | QUAD_IO_FAST, SECT_4K}, >> + {"EN25Q64", 0x1c3017, 0x0, 4 * 1024, 2048, RD_EXTN | QUAD_IO_FAST, SECT_4K}, >> + {"EN25Q128B", 0x1c3018, 0x0, 4 * 1024, 4096, RD_EXTN | QUAD_IO_FAST, SECT_4K}, >> + {"EN25S64", 0x1c3817, 0x0, 4 * 1024, 2048, RD_EXTN | QUAD_IO_FAST, SECT_4K}, > > Did you test this QUAD_IO_FAST ? > No because I don't have a board running U-Boot which has an EON flash mounted. These updates are purely based on the flash datasheet. [snip] Regards, Bin
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index cc4cd60..3e5c6e0 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -26,10 +26,10 @@ const struct spi_flash_params spi_flash_params_table[] = { {"AT25DF321A", 0x1f4701, 0x0, 4 * 1024, 1024, RD_NORM, SECT_4K}, #endif #ifdef CONFIG_SPI_FLASH_EON /* EON */ - {"EN25Q32B", 0x1c3016, 0x0, 64 * 1024, 64, RD_NORM, 0}, - {"EN25Q64", 0x1c3017, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K}, - {"EN25Q128B", 0x1c3018, 0x0, 64 * 1024, 256, RD_NORM, 0}, - {"EN25S64", 0x1c3817, 0x0, 64 * 1024, 128, RD_NORM, 0}, + {"EN25Q32B", 0x1c3016, 0x0, 4 * 1024, 1024, RD_EXTN | QUAD_IO_FAST, SECT_4K}, + {"EN25Q64", 0x1c3017, 0x0, 4 * 1024, 2048, RD_EXTN | QUAD_IO_FAST, SECT_4K}, + {"EN25Q128B", 0x1c3018, 0x0, 4 * 1024, 4096, RD_EXTN | QUAD_IO_FAST, SECT_4K}, + {"EN25S64", 0x1c3817, 0x0, 4 * 1024, 2048, RD_EXTN | QUAD_IO_FAST, SECT_4K}, #endif #ifdef CONFIG_SPI_FLASH_GIGADEVICE /* GIGADEVICE */ {"GD25Q64B", 0xc84017, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K},
Update supported read commands for EON flash parts to RD_EXTN and QUAD_IO_FAST per datasheet. Also update flash sector size to 4KiB as long as flash supports sector erase (20h) command. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- drivers/mtd/spi/sf_params.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)