From patchwork Thu Dec 31 01:33:16 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 41951 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 780E11007D2 for ; Thu, 31 Dec 2009 12:42:06 +1100 (EST) Received: from localhost ([127.0.0.1]:49823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQA39-0008Uz-Nm for incoming@patchwork.ozlabs.org; Wed, 30 Dec 2009 20:42:03 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NQ9v4-0005rC-7W for qemu-devel@nongnu.org; Wed, 30 Dec 2009 20:33:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NQ9uz-0005oP-IM for qemu-devel@nongnu.org; Wed, 30 Dec 2009 20:33:41 -0500 Received: from [199.232.76.173] (port=40613 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NQ9uz-0005oK-2P for qemu-devel@nongnu.org; Wed, 30 Dec 2009 20:33:37 -0500 Received: from mail-fx0-f222.google.com ([209.85.220.222]:55351) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NQ9uy-00031z-Kh for qemu-devel@nongnu.org; Wed, 30 Dec 2009 20:33:36 -0500 Received: by mail-fx0-f222.google.com with SMTP id 22so15607328fxm.2 for ; Wed, 30 Dec 2009 17:33:36 -0800 (PST) Received: by 10.223.77.84 with SMTP id f20mr10650223fak.92.1262223216243; Wed, 30 Dec 2009 17:33:36 -0800 (PST) Received: from localhost.localdomain (a88-114-220-92.elisa-laajakaista.fi [88.114.220.92]) by mx.google.com with ESMTPS id 18sm20568832fks.34.2009.12.30.17.33.34 (version=SSLv3 cipher=RC4-MD5); Wed, 30 Dec 2009 17:33:35 -0800 (PST) From: "Kirill A. Shutemov" To: qemu-devel@nongnu.org Date: Thu, 31 Dec 2009 03:33:16 +0200 Message-Id: <1262223199-19062-6-git-send-email-kirill@shutemov.name> X-Mailer: git-send-email 1.6.5.7 In-Reply-To: <1262223199-19062-5-git-send-email-kirill@shutemov.name> References: <1262223199-19062-1-git-send-email-kirill@shutemov.name> <1262223199-19062-2-git-send-email-kirill@shutemov.name> <1262223199-19062-3-git-send-email-kirill@shutemov.name> <1262223199-19062-4-git-send-email-kirill@shutemov.name> <1262223199-19062-5-git-send-email-kirill@shutemov.name> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: "Kirill A. Shutemov" Subject: [Qemu-devel] [PATCH 06/14] block/vvfat.c: fix warnings with _FORTIFY_SOURCE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org CC block/vvfat.o cc1: warnings being treated as errors block/vvfat.c: In function 'commit_one_file': block/vvfat.c:2259: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make: *** [block/vvfat.o] Error 1 CC block/vvfat.o In file included from /usr/include/stdio.h:912, from ./qemu-common.h:19, from block/vvfat.c:27: In function 'snprintf', inlined from 'init_directories' at block/vvfat.c:871, inlined from 'vvfat_open' at block/vvfat.c:1068: /usr/include/bits/stdio2.h:65: error: call to __builtin___snprintf_chk will always overflow destination buffer make: *** [block/vvfat.o] Error 1 Signed-off-by: Kirill A. Shutemov --- block/vvfat.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 063f731..a7ec6b7 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -868,7 +868,8 @@ static int init_directories(BDRVVVFATState* s, { direntry_t* entry=array_get_next(&(s->directory)); entry->attributes=0x28; /* archive | volume label */ - snprintf((char*)entry->name,11,"QEMU VVFAT"); + snprintf((char*)entry->name,8,"QEMU VV"); + snprintf((char*)entry->extension,3,"FAT"); } /* Now build FAT, and write back information into directory */ @@ -2256,7 +2257,10 @@ static int commit_one_file(BDRVVVFATState* s, c = c1; } - ftruncate(fd, size); + if (ftruncate(fd, size)) { + perror("ftruncate()"); + abort(); + } close(fd); return commit_mappings(s, first_cluster, dir_index);