| Message ID | 1418200648-32656-5-git-send-email-Ying.Liu@freescale.com |
|---|---|
| State | Needs Review / ACK, archived |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
| robh/patch-applied | success |
On Wed, Dec 10, 2014 at 04:37:17PM +0800, Liu Ying wrote: > The MIPI DSI bus driver would try to add a DSI device for a host's every > child node which contains the reg property. Unfortunately, the existing > i.MX6Q/SDL MIPI DSI host device tree node's child nodes contain the reg There aren't any existing nodes for the DSI host on i.MX. This patch series adds support for them. > property, but the child nodes are ports pointing to dedicated CRTCs. > So, this patch phases out the child nodes with input-port property before > adding DSI devices for them and updates the MIPI DSI bus OF binding > documentation. > > Signed-off-by: Liu Ying <Ying.Liu@freescale.com> > --- > Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt | 4 ++++ > drivers/gpu/drm/drm_mipi_dsi.c | 5 +++-- > 2 files changed, 7 insertions(+), 2 deletions(-) Sorry, but NAK. There's no need for this special-case. I'll go into more detail in response to patch 09/15. Thierry
Hi Thierry, On 12/10/2014 08:21 PM, Thierry Reding wrote: > On Wed, Dec 10, 2014 at 04:37:17PM +0800, Liu Ying wrote: >> The MIPI DSI bus driver would try to add a DSI device for a host's every >> child node which contains the reg property. Unfortunately, the existing >> i.MX6Q/SDL MIPI DSI host device tree node's child nodes contain the reg > > There aren't any existing nodes for the DSI host on i.MX. This patch > series adds support for them. There are existing nodes for the DSI host node. Please find them in arch/arm/boot/dts/imx6qdl.dtsi and arch/arm/boot/dts/imx6q.dts. The DSI host node contains two child nodes for i.MX6DL and another two for i.MX6Q. Each child node has a reg property embedded. > >> property, but the child nodes are ports pointing to dedicated CRTCs. >> So, this patch phases out the child nodes with input-port property before >> adding DSI devices for them and updates the MIPI DSI bus OF binding >> documentation. >> >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >> --- >> Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt | 4 ++++ >> drivers/gpu/drm/drm_mipi_dsi.c | 5 +++-- >> 2 files changed, 7 insertions(+), 2 deletions(-) > > Sorry, but NAK. There's no need for this special-case. I'll go into more > detail in response to patch 09/15. Thanks for reviewing the patches. Any idea how to handle the special case? The existing child nodes for the DSI host node do have the reg properties embedded. Regards, Liu Ying > > Thierry > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Thierry, On 12/11/2014 10:52 AM, Liu Ying wrote: > Hi Thierry, > > On 12/10/2014 08:21 PM, Thierry Reding wrote: >> On Wed, Dec 10, 2014 at 04:37:17PM +0800, Liu Ying wrote: >>> The MIPI DSI bus driver would try to add a DSI device for a host's every >>> child node which contains the reg property. Unfortunately, the existing >>> i.MX6Q/SDL MIPI DSI host device tree node's child nodes contain the reg >> >> There aren't any existing nodes for the DSI host on i.MX. This patch >> series adds support for them. > > There are existing nodes for the DSI host node. Please find them in > arch/arm/boot/dts/imx6qdl.dtsi and arch/arm/boot/dts/imx6q.dts. The DSI > host node contains two child nodes for i.MX6DL and another two for > i.MX6Q. Each child node has a reg property embedded. > >> >>> property, but the child nodes are ports pointing to dedicated CRTCs. >>> So, this patch phases out the child nodes with input-port property >>> before >>> adding DSI devices for them and updates the MIPI DSI bus OF binding >>> documentation. >>> >>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com> >>> --- >>> Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt | 4 ++++ >>> drivers/gpu/drm/drm_mipi_dsi.c | 5 +++-- >>> 2 files changed, 7 insertions(+), 2 deletions(-) >> >> Sorry, but NAK. There's no need for this special-case. I'll go into more >> detail in response to patch 09/15. > > Thanks for reviewing the patches. > > Any idea how to handle the special case? The existing child nodes for > the DSI host node do have the reg properties embedded. > I see your suggestions on this topic in the comments for patch 09/15. I will try to move the existing child nodes into a parent port node. Liu Ying > >> >> Thierry >> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt b/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt index 973c272..1a1d3c1 100644 --- a/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt +++ b/Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt @@ -36,6 +36,10 @@ Peripherals are represented as child nodes of the DSI host's node. Properties described here apply to all DSI peripherals, but individual bindings may want to define additional, device-specific properties. +Please, do not add the input-port property to the child nodes which represent +peripherals. Otherwise, the peripherals would be omitted by the MIPI DSI bus +driver. + Required properties: - reg: The virtual channel number of a DSI peripheral. Must be in the range from 0 to 3. diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index c0644bb..9adacfe 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -176,8 +176,9 @@ int mipi_dsi_host_register(struct mipi_dsi_host *host) struct device_node *node; for_each_available_child_of_node(host->dev->of_node, node) { - /* skip nodes without reg property */ - if (!of_find_property(node, "reg", NULL)) + /* skip nodes without reg property or with input-port property */ + if (!of_find_property(node, "reg", NULL) || + of_find_property(node, "input-port", NULL)) continue; of_mipi_dsi_device_add(host, node); }
The MIPI DSI bus driver would try to add a DSI device for a host's every child node which contains the reg property. Unfortunately, the existing i.MX6Q/SDL MIPI DSI host device tree node's child nodes contain the reg property, but the child nodes are ports pointing to dedicated CRTCs. So, this patch phases out the child nodes with input-port property before adding DSI devices for them and updates the MIPI DSI bus OF binding documentation. Signed-off-by: Liu Ying <Ying.Liu@freescale.com> --- Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt | 4 ++++ drivers/gpu/drm/drm_mipi_dsi.c | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-)