From patchwork Wed Dec 30 22:59:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ren=C3=A9_Bolldorf?= X-Patchwork-Id: 41944 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 24E211007D2 for ; Thu, 31 Dec 2009 10:00:04 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbZL3W76 (ORCPT ); Wed, 30 Dec 2009 17:59:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753237AbZL3W76 (ORCPT ); Wed, 30 Dec 2009 17:59:58 -0500 Received: from mail-fx0-f225.google.com ([209.85.220.225]:39295 "EHLO mail-fx0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752749AbZL3W74 (ORCPT ); Wed, 30 Dec 2009 17:59:56 -0500 Received: by fxm25 with SMTP id 25so6330762fxm.21 for ; Wed, 30 Dec 2009 14:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=UAXNnk/e6XjJaWm6k14L6Km2eQCabkTzZJb2KUwxItM=; b=bxRlJtQXWy25L8V877JaH7PPlDElggWZD7VTpZ/ZxIhw9XTPUdhofE4paHYcdCJBbk 0Vq/JzKbIZdFrNg80OxxV/50O2E9PoaMCvT4vV3rB87QwqKoSZm0YlmVTH4noqv+0hG7 lLMIQgA1oatGS2VcfYqqILDdj4EiNg+2HFSmM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=TM1rG8dLOcwE6z07WV/jicBfbXIE6/a7AZuesS4ndnYKSQ+4gRlNDiFnrO+wbJAWv5 cu4oN2admmrK9icjOwdq4wOGs7bFZBkb/XnbATX/rm/FTGypIe1kZpyFmm08N0RWKrPM KWmD5EVky0JPlXANmLdvBh4Hcj6iBI4HrtHX0= Received: by 10.223.77.19 with SMTP id e19mr342352fak.39.1262213995318; Wed, 30 Dec 2009 14:59:55 -0800 (PST) Received: from ?192.168.1.2? (dslb-088-071-131-209.pools.arcor-ip.net [88.71.131.209]) by mx.google.com with ESMTPS id 13sm4737671fxm.5.2009.12.30.14.59.54 (version=SSLv3 cipher=RC4-MD5); Wed, 30 Dec 2009 14:59:54 -0800 (PST) Message-ID: <4B3BDB66.6000008@googlemail.com> Date: Wed, 30 Dec 2009 23:59:50 +0100 From: =?ISO-8859-1?Q?Ren=E9_Bolldorf?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 MIME-Version: 1.0 To: Jeff Garzik CC: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset() Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org We don't need this ;-). Best regards René Bolldorf & a happy new year in advance. --- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- ./drivers/ata/libata-eh.c 2009-12-30 23:44:05.578988545 +0100 +++ ./drivers/ata/libata-eh.c 2009-12-30 23:45:06.991987607 +0100 @@ -1505,9 +1505,6 @@ static unsigned int atapi_eh_request_sen DPRINTK("ATAPI request sense\n"); - /* FIXME: is this needed? */ - memset(sense_buf, 0, SCSI_SENSE_BUFFERSIZE); - /* initialize sense_buf with the error register, * for the case where they are -not- overwritten */