| Message ID | 58905.1418159750@turing-police.cc.vt.edu |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 2014-12-09 at 16:15 -0500, Valdis Kletnieks wrote: > commit 46e5da40ae (net: qdisc: use rcu prefix and silence > sparse warnings) triggers a spurious warning: > > net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! > > The code should be using the _bh variant of rcu_dereference. > > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> > --- > net/sched/sch_fq_codel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Eric Dumazet <edumazet@google.com> Thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/09/2014 01:42 PM, Eric Dumazet wrote: > On Tue, 2014-12-09 at 16:15 -0500, Valdis Kletnieks wrote: >> commit 46e5da40ae (net: qdisc: use rcu prefix and silence >> sparse warnings) triggers a spurious warning: >> >> net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! >> >> The code should be using the _bh variant of rcu_dereference. >> >> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> >> --- >> net/sched/sch_fq_codel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Eric Dumazet <edumazet@google.com> > > Thanks ! > > Great thanks for finding/fixing! Acked-by: John Fastabend <john.r.fastabend@intel.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu> Date: Tue, 09 Dec 2014 16:15:50 -0500 > commit 46e5da40ae (net: qdisc: use rcu prefix and silence > sparse warnings) triggers a spurious warning: > > net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! > > The code should be using the _bh variant of rcu_dereference. > > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c index b9ca32ebc1de..1e52decb7b59 100644 --- a/net/sched/sch_fq_codel.c +++ b/net/sched/sch_fq_codel.c @@ -94,7 +94,7 @@ static unsigned int fq_codel_classify(struct sk_buff *skb, struct Qdisc *sch, TC_H_MIN(skb->priority) <= q->flows_cnt) return TC_H_MIN(skb->priority); - filter = rcu_dereference(q->filter_list); + filter = rcu_dereference_bh(q->filter_list); if (!filter) return fq_codel_hash(q, skb) + 1;
commit 46e5da40ae (net: qdisc: use rcu prefix and silence sparse warnings) triggers a spurious warning: net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! The code should be using the _bh variant of rcu_dereference. Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> --- net/sched/sch_fq_codel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)