diff mbox

Do not download packages for graphite loop optimizations by default when using ./contrib/download_prerequisites

Message ID CADj25HMsBT07eoQE9nOmEyzLpkUPu=Kd=gbnuzM5zF9ZzuHiCw@mail.gmail.com
State New
Headers show

Commit Message

Chung-Ju Wu Dec. 9, 2014, 5:36 a.m. UTC 
Hi, all,

In the discussion thread last year:
  https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html

I extended the script ./contrib/download_prerequisites so that it can
download isl and cloog packages for graphite loop optimizations.
The patch was proposed to use GRAPHITE_LOOP_OPT=no by default.
However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes:
  https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=199297

I am sorry about my carelessness and I would like to propose a new patch
to fix it.  The plaintext ChangeLog and patch are as follow:




Is this patch OK for trunk?

Or we can still keep it "yes" since it has been using GRAPHITE_LOOP_OPT=yes
for a long time.  In that case, I will help to update the comment accordingly.

Any comment? :)


Best regards,
jasonwucj

Comments

Richard Biener Dec. 9, 2014, 1:16 p.m. UTC | #1 
On Tue, Dec 9, 2014 at 6:36 AM, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
> Hi, all,
>
> In the discussion thread last year:
>   https://gcc.gnu.org/ml/gcc-patches/2013-05/msg01334.html
>
> I extended the script ./contrib/download_prerequisites so that it can
> download isl and cloog packages for graphite loop optimizations.
> The patch was proposed to use GRAPHITE_LOOP_OPT=no by default.
> However, the change I committed into trunk is setting GRAPHITE_LOOP_OPT=yes:
>   https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=199297
>
> I am sorry about my carelessness and I would like to propose a new patch
> to fix it.  The plaintext ChangeLog and patch are as follow:

I'd say keep it as =yes (now that we only need ISL) and adjust the comment
instead.

Richard.

>
> Index: contrib/ChangeLog
> ===================================================================
> --- contrib/ChangeLog   (revision 218505)
> +++ contrib/ChangeLog   (working copy)
> @@ -1,3 +1,7 @@
> +2014-12-09  Chung-Ju Wu  <jasonwucj@gmail.com>
> +
> +       * download_prerequisites: Set GRAPHITE_LOOP_OPT=no by default.
> +
>  2014-12-04  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>
>         * check_GNU_style.sh: Warn for incorrect number of spaces in function
>
>
> Index: contrib/download_prerequisites
> ===================================================================
> --- contrib/download_prerequisites      (revision 218505)
> +++ contrib/download_prerequisites      (working copy)
> @@ -22,7 +22,7 @@
>  # If you want to build GCC with the Graphite loop optimizations,
>  # set GRAPHITE_LOOP_OPT=yes to download optional prerequisties
>  # ISL Library and CLooG.
> -GRAPHITE_LOOP_OPT=yes
> +GRAPHITE_LOOP_OPT=no
>
>  # Necessary to build GCC.
>  MPFR=mpfr-2.4.2
>
>
> Is this patch OK for trunk?
>
> Or we can still keep it "yes" since it has been using GRAPHITE_LOOP_OPT=yes
> for a long time.  In that case, I will help to update the comment accordingly.
>
> Any comment? :)
>
>
> Best regards,
> jasonwucj
diff mbox

Patch

Index: contrib/ChangeLog
===================================================================
--- contrib/ChangeLog   (revision 218505)
+++ contrib/ChangeLog   (working copy)
@@ -1,3 +1,7 @@ 
+2014-12-09  Chung-Ju Wu  <jasonwucj@gmail.com>
+
+       * download_prerequisites: Set GRAPHITE_LOOP_OPT=no by default.
+
 2014-12-04  Thomas Preud'homme  <thomas.preudhomme@arm.com>

        * check_GNU_style.sh: Warn for incorrect number of spaces in function


Index: contrib/download_prerequisites
===================================================================
--- contrib/download_prerequisites      (revision 218505)
+++ contrib/download_prerequisites      (working copy)
@@ -22,7 +22,7 @@ 
 # If you want to build GCC with the Graphite loop optimizations,
 # set GRAPHITE_LOOP_OPT=yes to download optional prerequisties
 # ISL Library and CLooG.
-GRAPHITE_LOOP_OPT=yes
+GRAPHITE_LOOP_OPT=no

 # Necessary to build GCC.
 MPFR=mpfr-2.4.2