diff mbox

[6/6] package/mpd: enable OSS support

Message ID 1418078694-26331-6-git-send-email-jkrause@posteo.de
State Accepted
Headers show

Commit Message

Jörg Krause Dec. 8, 2014, 10:44 p.m. UTC
Add support for the OSS (Open Sound System).

Signed-off-by: Jörg Krause <jkrause@posteo.de>
---
 package/mpd/Config.in | 5 +++++
 package/mpd/mpd.mk    | 6 ++++++
 2 files changed, 11 insertions(+)

Comments

Thomas Petazzoni Dec. 9, 2014, 7:16 p.m. UTC | #1
Dear Jörg Krause,

On Mon,  8 Dec 2014 23:44:54 +0100, Jörg Krause wrote:
> Add support for the OSS (Open Sound System).
> 
> Signed-off-by: Jörg Krause <jkrause@posteo.de>

Applied, after adjusting the commit title: the commit is not enabling
OSS support, it's adding an option to enable or disable the OSS
support. And in practice it actually disables it: it was enabled by
default by the mpd configure.ac script, unless --disable-oss is passed.
Now that we have the option which defaults to not enabled, the OSS
support will be disabled by default. I believe this is good as on most
Linux systems, ALSA is now used for audio, and OSS is deprecated.

Thanks,

Thomas
diff mbox

Patch

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 57ed434..50f9ad0 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -241,6 +241,11 @@  comment "jack support needs a toolchain w/ largefile"
 	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_LARGEFILE
 
+config BR2_PACKAGE_MPD_OSS
+	bool "oss"
+	help
+	  Enable OSS (Open Sound System) output support.
+
 config BR2_PACKAGE_MPD_PULSEAUDIO
 	bool "pulseaudio"
 	depends on BR2_LARGEFILE # pulseaudio -> libsndfile
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index 85bbe8b..132ad44 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -175,6 +175,12 @@  else
 MPD_CONF_OPTS += --disable-opus
 endif
 
+ifeq ($(BR2_PACKAGE_MPD_OSS),y)
+MPD_CONF_OPTS += --enable-oss
+else
+MPD_CONF_OPTS += --disable-oss
+endif
+
 ifeq ($(BR2_PACKAGE_MPD_PULSEAUDIO),y)
 MPD_DEPENDENCIES += pulseaudio
 MPD_CONF_OPTS += --enable-pulse