From patchwork Tue Dec 29 19:49:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 41889 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 690EEB6EEB for ; Wed, 30 Dec 2009 06:50:40 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751934AbZL2Tty (ORCPT ); Tue, 29 Dec 2009 14:49:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751898AbZL2Ttx (ORCPT ); Tue, 29 Dec 2009 14:49:53 -0500 Received: from mail.vyatta.com ([76.74.103.46]:38966 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbZL2Ttu (ORCPT ); Tue, 29 Dec 2009 14:49:50 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.vyatta.com (Postfix) with ESMTP id C97CF4F4047; Tue, 29 Dec 2009 11:49:44 -0800 (PST) X-Virus-Scanned: amavisd-new at tahiti.vyatta.com Received: from mail.vyatta.com ([127.0.0.1]) by localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26P72k6EdmMY; Tue, 29 Dec 2009 11:49:40 -0800 (PST) Received: from nehalam (pool-71-117-243-57.ptldor.fios.verizon.net [71.117.243.57]) by mail.vyatta.com (Postfix) with ESMTP id D6BFE4F4046; Tue, 29 Dec 2009 11:49:39 -0800 (PST) Date: Tue, 29 Dec 2009 11:49:38 -0800 From: Stephen Hemminger To: Michael Breuer Cc: Andrew Morton , "Berck E. Nash" , "linux-kernel@vger.kernel.org" , netdev@vger.kernel.org Subject: Re: sky2 panic in 2.6.32.1 under load (new oops) Message-ID: <20091229114938.1f4d1c5c@nehalam> In-Reply-To: <4B3A5048.9090700@majjas.com> References: <4B300A2A.8040305@gmail.com> <4B300E30.9090707@majjas.com> <4B3114E3.1070602@majjas.com> <4B329FA3.9090904@majjas.com> <20091223230102.4bb0100e.akpm@linux-foundation.org> <4B34E847.8010809@majjas.com> <20091225152200.1cf11dfe@nehalam> <4B3581C7.8000702@majjas.com> <20091226095723.7ac82b18@nehalam> <4B367409.5060202@majjas.com> <4B379378.4000102@majjas.com> <20091227102238.0df149f9@nehalam> <4B37B7E2.5070307@majjas.com> <20091229093023.3ad24786@nehalam> <4B3A5048.9090700@majjas.com> Organization: Vyatta X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.3; x86_64-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch will dump more info in case of hardware error. --- a/drivers/net/sky2.c 2009-12-29 11:30:06.441137685 -0800 +++ b/drivers/net/sky2.c 2009-12-29 11:46:37.389262922 -0800 @@ -2629,12 +2625,71 @@ static void sky2_hw_error(struct sky2_hw } } +static void dump_txring(struct sky2_hw *hw, unsigned port) +{ + struct sky2_port *sky2 = netdev_priv(hw->dev[port]); + int sop = 1; + unsigned idx; + + printk(KERN_INFO PFX "Tx ring pending=%u...%u report=%d done=%d\n", + sky2->tx_cons, sky2->tx_prod, + sky2_read16(hw, port == 0 ? STAT_TXA1_RIDX : STAT_TXA2_RIDX), + sky2_read16(hw, Q_ADDR(txqaddr[port], Q_DONE))); + + /* Dump contents of tx ring */ + for (idx = sky2->tx_next; + idx != sky2->tx_prod && idx < sky2->tx_ring_size; + idx = RING_NEXT(idx, sky2->tx_ring_size)) { + const struct sky2_tx_le *le = sky2->tx_le + idx; + u32 a = le32_to_cpu(le->addr); + + if (sop) + printk(KERN_DEBUG "%u:", idx); + sop = 0; + + switch(le->opcode & ~HW_OWNER) { + case OP_ADDR64: + printk(" %#x:", a); + break; + case OP_LRGLEN: + printk(" mtu=%d", a); + break; + case OP_VLAN: + printk(" vlan=%d", be16_to_cpu(le->length)); + break; + case OP_TCPLISW: + printk(" csum=%#x", a); + break; + case OP_LARGESEND: + printk(" tso=%#x(%d)", a, le16_to_cpu(le->length)); + break; + case OP_PACKET: + printk(" %#x(%d)", a, le16_to_cpu(le->length)); + break; + case OP_BUFFER: + printk(" frag=%#x(%d)", a, le16_to_cpu(le->length)); + break; + default: + printk(" op=%#x,%#x(%d)", le->opcode, a, + le16_to_cpu(le->length)); + } + + if (le->ctrl & EOP) { + printk("\n"); + sop = 1; + } + } +} + static void sky2_hw_intr(struct sky2_hw *hw) { struct pci_dev *pdev = hw->pdev; u32 status = sky2_read32(hw, B0_HWE_ISRC); u32 hwmsk = sky2_read32(hw, B0_HWE_IMSK); + printk(KERN_DEBUG PFX "hardware interrupt status %#x\n", status); + dump_txring(hw, 0); + status &= hwmsk; if (status & Y2_IS_TIST_OV)