Removal of duplication of -frounding-math for math tests
diff mbox

Message ID CAMXFM3skV_Gu29BkTv81Efw9eiK+Zs3NMFTFzCs73yhMDTb2fA@mail.gmail.com
State New
Headers show

Commit Message

Andrew Senkevich Dec. 8, 2014, 11:32 a.m. UTC
2014-12-06 1:36 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> OK with a proper ChangeLog entry (which means naming each variable
> changed, along the lines of

        * math/Makefile (CFLAGS-test-float.c): Remove -frounding-math.
        (CFLAGS-test-double.c): Likewise.
        (CFLAGS-test-ldouble.c): Likewise.
        (CPPFLAGS-test-ifloat.c): Likewise.
        (CPPFLAGS-test-idouble.c): Likewise.
        (CPPFLAGS-test-ildoubl.c): Likewise.
        (CFLAGS-test-test-fenv.c): Remove variable.
        (CFLAGS-test-misc.c): Likewise.


Ok for trunk?


--
WBR,
Andrew

Comments

Joseph Myers Dec. 8, 2014, 3:34 p.m. UTC | #1
On Mon, 8 Dec 2014, Andrew Senkevich wrote:

> 2014-12-06 1:36 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> > OK with a proper ChangeLog entry (which means naming each variable
> > changed, along the lines of
> 
>         * math/Makefile (CFLAGS-test-float.c): Remove -frounding-math.
>         (CFLAGS-test-double.c): Likewise.
>         (CFLAGS-test-ldouble.c): Likewise.
>         (CPPFLAGS-test-ifloat.c): Likewise.
>         (CPPFLAGS-test-idouble.c): Likewise.
>         (CPPFLAGS-test-ildoubl.c): Likewise.
>         (CFLAGS-test-test-fenv.c): Remove variable.
>         (CFLAGS-test-misc.c): Likewise.

OK.
H.J. Lu Jan. 6, 2015, 2:34 p.m. UTC | #2
On Mon, Dec 8, 2014 at 7:34 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 8 Dec 2014, Andrew Senkevich wrote:
>
>> 2014-12-06 1:36 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
>> > OK with a proper ChangeLog entry (which means naming each variable
>> > changed, along the lines of
>>
>>         * math/Makefile (CFLAGS-test-float.c): Remove -frounding-math.
>>         (CFLAGS-test-double.c): Likewise.
>>         (CFLAGS-test-ldouble.c): Likewise.
>>         (CPPFLAGS-test-ifloat.c): Likewise.
>>         (CPPFLAGS-test-idouble.c): Likewise.
>>         (CPPFLAGS-test-ildoubl.c): Likewise.
>>         (CFLAGS-test-test-fenv.c): Remove variable.
>>         (CFLAGS-test-misc.c): Likewise.
>
> OK.
>

I checked it in.

Thanks.

Patch
diff mbox

diff --git a/math/Makefile b/math/Makefile
index 866bc0f..9ec450b 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -126,9 +126,9 @@  $(objpfx)test-ldouble.o: $(objpfx)libm-test.stmp
 $(objpfx)test-ildoubl.o: $(objpfx)libm-test.stmp
 endif

-CFLAGS-test-float.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
-CFLAGS-test-double.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
-CFLAGS-test-ldouble.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
+CFLAGS-test-float.c = -fno-inline -ffloat-store -fno-builtin
+CFLAGS-test-double.c = -fno-inline -ffloat-store -fno-builtin
+CFLAGS-test-ldouble.c = -fno-inline -ffloat-store -fno-builtin
 CFLAGS-test-tgmath.c = -fno-builtin
 # The following testcase uses very long lines (>3 million), so it may take a
 # while to compile it. See: http://llvm.org/bugs/show_bug.cgi?id=14106 and
@@ -136,15 +136,12 @@  CFLAGS-test-tgmath.c = -fno-builtin
 CFLAGS-test-tgmath2.c = -fno-builtin
 CFLAGS-test-tgmath-ret.c = -fno-builtin
 CFLAGS-test-powl.c = -fno-builtin
-CFLAGS-test-test-fenv.c = -frounding-math
-CFLAGS-test-misc.c = -frounding-math
 CPPFLAGS-test-ifloat.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-                        -DTEST_FAST_MATH -fno-builtin -frounding-math
+                        -DTEST_FAST_MATH -fno-builtin
 CPPFLAGS-test-idouble.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-                        -DTEST_FAST_MATH -fno-builtin -frounding-math
+                        -DTEST_FAST_MATH -fno-builtin
 CPPFLAGS-test-ildoubl.c = -U__LIBC_INTERNAL_MATH_INLINES -D__FAST_MATH__ \
-                         -DTEST_FAST_MATH -fno-builtin -frounding-math
-
+                         -DTEST_FAST_MATH -fno-builtin

 # The -lieee module sets the _LIB_VERSION_ switch to IEEE mode
 # for error handling in the -lm functions.