| Message ID | Pine.LNX.4.64.0912272227290.20548@ask.diku.dk |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> Thanks Julia! I added Christian Pellegrin who is the author of this driver in CC. An obvious copy/paste error :-) Regards, Oliver Acked-by: Oliver Hartkopp <oliver@hartkopp.net> > > Test the just-allocated value for NULL rather than some other value. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x,y; > statement S; > @@ > > x = \(kmalloc\|kcalloc\|kzalloc\)(...); > ( > if ((x) == NULL) S > | > if ( > - y > + x > == NULL) > S > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > drivers/net/can/mcp251x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c > --- a/drivers/net/can/mcp251x.c > +++ b/drivers/net/can/mcp251x.c > @@ -990,7 +990,7 @@ static int __devinit mcp251x_can_probe(s > goto error_tx_buf; > } > priv->spi_rx_buf = kmalloc(SPI_TRANSFER_BUF_LEN, GFP_KERNEL); > - if (!priv->spi_tx_buf) { > + if (!priv->spi_rx_buf) { > ret = -ENOMEM; > goto error_rx_buf; > } > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 28, 2009 at 2:49 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote: > Julia Lawall wrote: >> From: Julia Lawall <julia@diku.dk> > > Thanks Julia! > > I added Christian Pellegrin who is the author of this driver in CC. > > An obvious copy/paste error :-) > yes, exactly that: copy & paste is among the sweetest evils out there. I'll try the semantic checker myself next time. Thanks!
From: Julia Lawall <julia@diku.dk> Date: Sun, 27 Dec 2009 22:27:44 +0100 (CET) > From: Julia Lawall <julia@diku.dk> > > Test the just-allocated value for NULL rather than some other value. ... > Signed-off-by: Julia Lawall <julia@diku.dk> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -u -p a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c --- a/drivers/net/can/mcp251x.c +++ b/drivers/net/can/mcp251x.c @@ -990,7 +990,7 @@ static int __devinit mcp251x_can_probe(s goto error_tx_buf; } priv->spi_rx_buf = kmalloc(SPI_TRANSFER_BUF_LEN, GFP_KERNEL); - if (!priv->spi_tx_buf) { + if (!priv->spi_rx_buf) { ret = -ENOMEM; goto error_rx_buf; }