| Message ID | 1417976445-18860-1-git-send-email-antonynpavlov@gmail.com |
|---|---|
| State | New |
| Headers | show |
07.12.2014 21:20, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> > --- > hw/block/pflash_cfi02.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c > index 8513a17..389b4aa 100644 > --- a/hw/block/pflash_cfi02.c > +++ b/hw/block/pflash_cfi02.c > @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data) > > dc->realize = pflash_cfi02_realize; > dc->props = pflash_cfi02_properties; > + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); > } > > static const TypeInfo pflash_cfi02_info = { Hm. While the patch itself is trivial, and it _seems_ it fixes a bug, I'm not sure of possible effects of this. What prob it has now, does this device work? If yes, why it needs fixing? Do we care about compatibility with previous versions, about migration? Cc'ing block device people... Thanks, /mjt
On 10/12/2014 10:11, Michael Tokarev wrote: > 07.12.2014 21:20, Antony Pavlov wrote: >> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> >> --- >> hw/block/pflash_cfi02.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c >> index 8513a17..389b4aa 100644 >> --- a/hw/block/pflash_cfi02.c >> +++ b/hw/block/pflash_cfi02.c >> @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data) >> >> dc->realize = pflash_cfi02_realize; >> dc->props = pflash_cfi02_properties; >> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); >> } >> >> static const TypeInfo pflash_cfi02_info = { > > Hm. While the patch itself is trivial, and it _seems_ it > fixes a bug, I'm not sure of possible effects of this. > > What prob it has now, does this device work? If yes, > why it needs fixing? Do we care about compatibility > with previous versions, about migration? This affects nothing but help messages. Paolo
Applied to -trivial, thank you! /mjt
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index 8513a17..389b4aa 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block/pflash_cfi02.c @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data) dc->realize = pflash_cfi02_realize; dc->props = pflash_cfi02_properties; + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); } static const TypeInfo pflash_cfi02_info = {
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> --- hw/block/pflash_cfi02.c | 1 + 1 file changed, 1 insertion(+)