ACPI / blacklist: blacklist Win8 OSI for Dell Vostro 3546
diff mbox

Message ID 1417772164-28628-1-git-send-email-adam.lee@canonical.com
State New
Headers show

Commit Message

Adam Lee Dec. 5, 2014, 9:36 a.m. UTC
BugLink: http://bugs.launchpad.net/bugs/1383589

The wireless hotkey of Dell Vostro 3546 does not work with Win8 OSI. Due
to insufficient documentation for the driver implementation, blacklist
it as a workaround.

Signed-off-by: Adam Lee <adam.lee@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
(cherry picked from commit 222584647f2821c4d68421c1d07c89b375d501b2)
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
 drivers/acpi/blacklist.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Andy Whitcroft Dec. 5, 2014, 11:13 a.m. UTC | #1
On Fri, Dec 05, 2014 at 05:36:04PM +0800, Adam Lee wrote:
> BugLink: http://bugs.launchpad.net/bugs/1383589
> 
> The wireless hotkey of Dell Vostro 3546 does not work with Win8 OSI. Due
> to insufficient documentation for the driver implementation, blacklist
> it as a workaround.
> 
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> (cherry picked from commit 222584647f2821c4d68421c1d07c89b375d501b2)
> Signed-off-by: Adam Lee <adam.lee@canonical.com>

For which release(s) are you proposing this?

-apw
Adam Lee Dec. 5, 2014, 11:59 a.m. UTC | #2
On Fri, Dec 05, 2014 at 11:13:54AM +0000, Andy Whitcroft wrote:
> On Fri, Dec 05, 2014 at 05:36:04PM +0800, Adam Lee wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1383589
> > 
> > The wireless hotkey of Dell Vostro 3546 does not work with Win8 OSI. Due
> > to insufficient documentation for the driver implementation, blacklist
> > it as a workaround.
> > 
> > Signed-off-by: Adam Lee <adam.lee@canonical.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > (cherry picked from commit 222584647f2821c4d68421c1d07c89b375d501b2)
> > Signed-off-by: Adam Lee <adam.lee@canonical.com>
> 
> For which release(s) are you proposing this?

Trusty and Utopic, Vivid has already fixed this issue. Thanks.
Andy Whitcroft Dec. 5, 2014, 12:21 p.m. UTC | #3
On Fri, Dec 05, 2014 at 05:36:04PM +0800, Adam Lee wrote:
> BugLink: http://bugs.launchpad.net/bugs/1383589
> 
> The wireless hotkey of Dell Vostro 3546 does not work with Win8 OSI. Due
> to insufficient documentation for the driver implementation, blacklist
> it as a workaround.
> 
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> (cherry picked from commit 222584647f2821c4d68421c1d07c89b375d501b2)
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> ---
>  drivers/acpi/blacklist.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index 86f0bdb..1a00d17 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -355,6 +355,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		    DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3446"),
>  		},
>  	},
> +	{
> +	.callback = dmi_disable_osi_win8,
> +	.ident = "Dell Vostro 3546",
> +	.matches = {
> +		    DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		    DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3546"),
> +		},
> +	},
>  
>  	/*
>  	 * The following Lenovo models have a broken workaround in the
> -- 

Looks simple enough, cherry-pick from mainline.  

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Chris J Arges Dec. 5, 2014, 2:03 p.m. UTC | #4
Cleanly cherry-picks into both utopic/trusty.
--chris

On 12/05/2014 03:36 AM, Adam Lee wrote:
> BugLink: http://bugs.launchpad.net/bugs/1383589
> 
> The wireless hotkey of Dell Vostro 3546 does not work with Win8 OSI. Due
> to insufficient documentation for the driver implementation, blacklist
> it as a workaround.
> 
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> (cherry picked from commit 222584647f2821c4d68421c1d07c89b375d501b2)
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> ---
>  drivers/acpi/blacklist.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index 86f0bdb..1a00d17 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -355,6 +355,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		    DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3446"),
>  		},
>  	},
> +	{
> +	.callback = dmi_disable_osi_win8,
> +	.ident = "Dell Vostro 3546",
> +	.matches = {
> +		    DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +		    DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3546"),
> +		},
> +	},
>  
>  	/*
>  	 * The following Lenovo models have a broken workaround in the
>
Andy Whitcroft Dec. 5, 2014, 2:16 p.m. UTC | #5
Applied to Trusty and Utopic.

-apw

Patch
diff mbox

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index 86f0bdb..1a00d17 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -355,6 +355,14 @@  static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		    DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3446"),
 		},
 	},
+	{
+	.callback = dmi_disable_osi_win8,
+	.ident = "Dell Vostro 3546",
+	.matches = {
+		    DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		    DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3546"),
+		},
+	},
 
 	/*
 	 * The following Lenovo models have a broken workaround in the