diff mbox

[U-Boot,21/25] x86: Include FSP and CMC binary in the u-boot.rom build rules

Message ID 1417705413-19675-1-git-send-email-bmeng.cn@gmail.com
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Bin Meng Dec. 4, 2014, 3:03 p.m. UTC 
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
 Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Simon Glass Dec. 4, 2014, 11:57 p.m. UTC | #1 
Hi Bin,

On 4 December 2014 at 08:03, Bin Meng <bmeng.cn@gmail.com> wrote:
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>  Makefile | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c9ae77b..abfb74b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -976,6 +976,14 @@ ifneq ($(CONFIG_HAVE_MRC),)
>  IFDTOOL_FLAGS += -w $(CONFIG_X86_MRC_START):$(srctree)/board/$(BOARDDIR)/mrc.bin
>  endif
>
> +ifneq ($(CONFIG_HAVE_FSP),)
> +IFDTOOL_FLAGS += -w $(CONFIG_FSP_LOCATION):$(CONFIG_FSP_FILE)

Can we stay consistent - e.g. START instead of LOCATION? or ADDR?
Granted it's not 100% consistent now.

> +endif
> +
> +ifneq ($(CONFIG_HAVE_CMC),)
> +IFDTOOL_FLAGS += -w $(CONFIG_CMC_LOCATION):$(CONFIG_CMC_FILE)
> +endif
> +
>  ifneq ($(CONFIG_X86_OPTION_ROM_ADDR),)
>  IFDTOOL_FLAGS += -w $(CONFIG_X86_OPTION_ROM_ADDR):$(srctree)/board/$(BOARDDIR)/$(CONFIG_X86_OPTION_ROM_FILENAME)
>  endif
> --
> 1.8.2.1
>

Regards,
Simon
Bin Meng Dec. 5, 2014, 1:56 p.m. UTC | #2 
Hi Simon,

On Fri, Dec 5, 2014 at 7:57 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Bin,
>
> On 4 December 2014 at 08:03, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>  Makefile | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index c9ae77b..abfb74b 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -976,6 +976,14 @@ ifneq ($(CONFIG_HAVE_MRC),)
>>  IFDTOOL_FLAGS += -w $(CONFIG_X86_MRC_START):$(srctree)/board/$(BOARDDIR)/mrc.bin
>>  endif
>>
>> +ifneq ($(CONFIG_HAVE_FSP),)
>> +IFDTOOL_FLAGS += -w $(CONFIG_FSP_LOCATION):$(CONFIG_FSP_FILE)
>
> Can we stay consistent - e.g. START instead of LOCATION? or ADDR?
> Granted it's not 100% consistent now.

Sure. I believe we can use ADDR for all these blobs.

>> +endif
>> +
>> +ifneq ($(CONFIG_HAVE_CMC),)
>> +IFDTOOL_FLAGS += -w $(CONFIG_CMC_LOCATION):$(CONFIG_CMC_FILE)
>> +endif
>> +
>>  ifneq ($(CONFIG_X86_OPTION_ROM_ADDR),)
>>  IFDTOOL_FLAGS += -w $(CONFIG_X86_OPTION_ROM_ADDR):$(srctree)/board/$(BOARDDIR)/$(CONFIG_X86_OPTION_ROM_FILENAME)
>>  endif
>> --
>> 1.8.2.1
>>
>
> Regards,
> Simon

Regards,
Bin
diff mbox

Patch

diff --git a/Makefile b/Makefile
index c9ae77b..abfb74b 100644
--- a/Makefile
+++ b/Makefile
@@ -976,6 +976,14 @@  ifneq ($(CONFIG_HAVE_MRC),)
 IFDTOOL_FLAGS += -w $(CONFIG_X86_MRC_START):$(srctree)/board/$(BOARDDIR)/mrc.bin
 endif
 
+ifneq ($(CONFIG_HAVE_FSP),)
+IFDTOOL_FLAGS += -w $(CONFIG_FSP_LOCATION):$(CONFIG_FSP_FILE)
+endif
+
+ifneq ($(CONFIG_HAVE_CMC),)
+IFDTOOL_FLAGS += -w $(CONFIG_CMC_LOCATION):$(CONFIG_CMC_FILE)
+endif
+
 ifneq ($(CONFIG_X86_OPTION_ROM_ADDR),)
 IFDTOOL_FLAGS += -w $(CONFIG_X86_OPTION_ROM_ADDR):$(srctree)/board/$(BOARDDIR)/$(CONFIG_X86_OPTION_ROM_FILENAME)
 endif