Patchwork Fix a typo in 'P' packet processing for M68K.

login
register
mail settings
Submitter Kazu Hirata
Date Dec. 24, 2009, 12:33 a.m.
Message ID <20091224003324.A6E1F6F6226F@daisy.codesourcery.com>
Download mbox | patch
Permalink /patch/41776/
State New
Headers show

Comments

Kazu Hirata - Dec. 24, 2009, 12:33 a.m.
Hi,

Attached is a patch to fix a typo in 'P' packet processing for M68K.

Without this patch, QEMU fails to honor GDB's P packets from GDB
(writing to registers) for the address registers (A0 - A7).

The problem is because of an obvious typo.  Notice that the second
"if" condition is meant to be n < 16 in:

  if (n < 8) {
    :
  } else if (n < 8) {

I don't have a write access to the repository.  Could someone apply
this patch if it's OK?

Thanks in advance,

Kazu Hirata
Aurelien Jarno - Jan. 14, 2010, 2:39 p.m.
On Wed, Dec 23, 2009 at 04:33:24PM -0800, Kazu Hirata wrote:
> Hi,
> 
> Attached is a patch to fix a typo in 'P' packet processing for M68K.
> 
> Without this patch, QEMU fails to honor GDB's P packets from GDB
> (writing to registers) for the address registers (A0 - A7).
> 
> The problem is because of an obvious typo.  Notice that the second
> "if" condition is meant to be n < 16 in:
> 
>   if (n < 8) {
>     :
>   } else if (n < 8) {
> 
> I don't have a write access to the repository.  Could someone apply
> this patch if it's OK?

This patch looks ok, but is missing a Signed-of-by:

> Thanks in advance,
> 
> Kazu Hirata
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 055093f..1a1640a 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1014,7 +1014,7 @@ static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n)
>      if (n < 8) {
>          /* D0-D7 */
>          env->dregs[n] = tmp;
> -    } else if (n < 8) {
> +    } else if (n < 16) {
>          /* A0-A7 */
>          env->aregs[n - 8] = tmp;
>      } else {
> 
> 
>
Kazu Hirata - Jan. 14, 2010, 5:05 p.m.
Hi Aurelien,

>> I don't have a write access to the repository.  Could someone apply
>> this patch if it's OK?
> 
> This patch looks ok, but is missing a Signed-of-by:

Thank you for a review.  I'm going to resubmit the patch in the git style.

Kazu Hirata

Patch

diff --git a/gdbstub.c b/gdbstub.c
index 055093f..1a1640a 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1014,7 +1014,7 @@  static int cpu_gdb_write_register(CPUState *env, uint8_t *mem_buf, int n)
     if (n < 8) {
         /* D0-D7 */
         env->dregs[n] = tmp;
-    } else if (n < 8) {
+    } else if (n < 16) {
         /* A0-A7 */
         env->aregs[n - 8] = tmp;
     } else {