diff mbox

block: Use g_new0() for a bit of extra type checking

Message ID 1417697709-13087-1-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster Dec. 4, 2014, 12:55 p.m. UTC 
g_new(T, 1) is safer than g_malloc(sizeof(T)), because it returns T *
rather than void *, which lets the compiler catch more type errors.

Missed in commit 02c4f26.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 aio-posix.c | 2 +-
 aio-win32.c | 4 ++--
 async.c     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Max Reitz Dec. 4, 2014, 1:03 p.m. UTC | #1 
On 2014-12-04 at 13:55, Markus Armbruster wrote:
> g_new(T, 1) is safer than g_malloc(sizeof(T)), because it returns T *
> rather than void *, which lets the compiler catch more type errors.
>
> Missed in commit 02c4f26.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   aio-posix.c | 2 +-
>   aio-win32.c | 4 ++--
>   async.c     | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)

Thanks, applied to my block-next tree:

https://github.com/XanClic/qemu/commits/block-next
diff mbox

Patch

diff --git a/aio-posix.c b/aio-posix.c
index d3ac06e..cbd4c34 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -73,7 +73,7 @@  void aio_set_fd_handler(AioContext *ctx,
     } else {
         if (node == NULL) {
             /* Alloc and insert if it's not already there */
-            node = g_malloc0(sizeof(AioHandler));
+            node = g_new0(AioHandler, 1);
             node->pfd.fd = fd;
             QLIST_INSERT_HEAD(&ctx->aio_handlers, node, node);
 
diff --git a/aio-win32.c b/aio-win32.c
index d81313b..e6f4ced 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -67,7 +67,7 @@  void aio_set_fd_handler(AioContext *ctx,
 
         if (node == NULL) {
             /* Alloc and insert if it's not already there */
-            node = g_malloc0(sizeof(AioHandler));
+            node = g_new0(AioHandler, 1);
             node->pfd.fd = fd;
             QLIST_INSERT_HEAD(&ctx->aio_handlers, node, node);
         }
@@ -129,7 +129,7 @@  void aio_set_event_notifier(AioContext *ctx,
     } else {
         if (node == NULL) {
             /* Alloc and insert if it's not already there */
-            node = g_malloc0(sizeof(AioHandler));
+            node = g_new0(AioHandler, 1);
             node->e = e;
             node->pfd.fd = (uintptr_t)event_notifier_get_handle(e);
             node->pfd.events = G_IO_IN;
diff --git a/async.c b/async.c
index 6e1b282..3939b79 100644
--- a/async.c
+++ b/async.c
@@ -44,7 +44,7 @@  struct QEMUBH {
 QEMUBH *aio_bh_new(AioContext *ctx, QEMUBHFunc *cb, void *opaque)
 {
     QEMUBH *bh;
-    bh = g_malloc0(sizeof(QEMUBH));
+    bh = g_new0(QEMUBH, 1);
     bh->ctx = ctx;
     bh->cb = cb;
     bh->opaque = opaque;