diff mbox

[iproute2,3/6] bridge/fdb: add flag/indication for FDB entry synced from offload device

Message ID 1417683438-10935-4-git-send-email-jiri@resnulli.us
State Changes Requested, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Jiri Pirko Dec. 4, 2014, 8:57 a.m. UTC 
From: Scott Feldman <sfeldma@gmail.com>

Add NTF_EXT_LEARNED flag to neigh flags to indicate FDB entry learned by
device has been learned externally to bridge FDB.  For these entries,
add "external" annotation in bridge fdb show output:

  00:02:00:00:03:00 dev swp2 used 2/2 master br0 external
  00:02:00:00:03:00 dev swp2 self permanent

In the example above, 00:02:00:00:03:00 is shown twice on dev swp2.  The
first entry if from the bridge (master) and is marked as "external" by
the offload device.  The second entry is from the brport offload device (self),
and was learned by the device.

Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 bridge/fdb.c              | 2 ++
 include/linux/neighbour.h | 1 +
 2 files changed, 3 insertions(+)

Comments

Jamal Hadi Salim Dec. 4, 2014, 1:19 p.m. UTC | #1 
On 12/04/14 03:57, Jiri Pirko wrote:
> From: Scott Feldman <sfeldma@gmail.com>
>

Did i say i like it already?;->

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Hemminger Dec. 24, 2014, 8:39 p.m. UTC | #2 
On Thu,  4 Dec 2014 09:57:15 +0100
Jiri Pirko <jiri@resnulli.us> wrote:

> From: Scott Feldman <sfeldma@gmail.com>
> 
> Add NTF_EXT_LEARNED flag to neigh flags to indicate FDB entry learned by
> device has been learned externally to bridge FDB.  For these entries,
> add "external" annotation in bridge fdb show output:
> 
>   00:02:00:00:03:00 dev swp2 used 2/2 master br0 external
>   00:02:00:00:03:00 dev swp2 self permanent
> 
> In the example above, 00:02:00:00:03:00 is shown twice on dev swp2.  The
> first entry if from the bridge (master) and is marked as "external" by
> the offload device.  The second entry is from the brport offload device (self),
> and was learned by the device.
> 
> Signed-off-by: Scott Feldman <sfeldma@gmail.com>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>

Does not apply to current code.
Please resubmit (with out the change to neighbour.h which is already there).

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/bridge/fdb.c b/bridge/fdb.c
index d678342..c01a502 100644
--- a/bridge/fdb.c
+++ b/bridge/fdb.c
@@ -154,6 +154,8 @@  int print_fdb(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
 		fprintf(fp, "master ");
 	if (r->ndm_flags & NTF_ROUTER)
 		fprintf(fp, "router ");
+	if (r->ndm_flags & NTF_EXT_LEARNED)
+		fprintf(fp, "external ");
 
 	fprintf(fp, "%s\n", state_n2a(r->ndm_state));
 	return 0;
diff --git a/include/linux/neighbour.h b/include/linux/neighbour.h
index 4a1d7e9..3a9b0df 100644
--- a/include/linux/neighbour.h
+++ b/include/linux/neighbour.h
@@ -40,6 +40,7 @@  enum {
 
 #define NTF_SELF	0x02
 #define NTF_MASTER	0x04
+#define NTF_EXT_LEARNED	0x10
 
 /*
  *	Neighbor Cache Entry States.